Update packages and pointers to use SAI1.6 headers. #4597

smaheshm · 2020-05-14T19:56:07Z

- Why I did it

Update sonic-sairedis pointer to use SAI1.6 headers

ebdf4ff (HEAD -> master, origin/master, origin/HEAD) [build]: support lgtm build for python library (#615)                                                                            
c819dc7 Change log level for not implemented port attributes and skipped mac learning (#610)                                                                                          
d12646c [MultiDB] use new multiDB API/cmd in new added codes (#611)                                                                                                                   
88a1982 [syncd] Use steady clock for TimerWatchdog (#613)                                                                                                                             
e50cf66 updating sonic-sairedis submodule to include SAI 1.6 headers                                                                                                                  
fea8e05 [py] Add sairedis python module skeleton (#607)                                                                                                                               
1a61519 [saiplayer] Fix notification pointers (#604)                                                                                                                                  
a77fc0a [sairedis] [meta] Support connect to existing switch (#602)                                                                                                                   
0b43cab [vs] Make default port admin state to false (#603)

- How I did it

Updated sonic-sairedis submodule.
Updated pointer brcm-sai debian package
Merged changes from Mellanox to use SAI1.6

- How to verify it

Built "target/sonic-broadcom.bin", loading and verify basic connective on lab switch

- Description for the changelog

Updated sonic-sairedis submodule.
Updated pointer brcm-sai debian package
Merged changes from Mellanox to use SAI1.6

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>

[Mellanox] Update SAI (release:v1.16.3; API:v1.6)

lguohan · 2020-05-14T21:33:44Z

build failures

smaheshm · 2020-05-14T22:14:00Z

retest broadcom please

… 1.16.3 (API:v1.6) Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>

[Mellanox] Update SDK to 4.4.0914 and FW to xx.2007.1112 to match SAI…

akokhan · 2020-05-20T13:04:16Z

retest vs please

akokhan · 2020-05-20T13:04:24Z

retest mellanox please

lguohan · 2020-05-21T03:41:52Z

why are mellanox and vs failing?

akokhan · 2020-05-22T07:54:54Z

retest vs please

akokhan · 2020-05-22T07:55:05Z

retest mellanox please

lguohan · 2020-05-27T20:19:34Z

@smaheshm, what is the issue here?

smaheshm · 2020-05-27T23:48:57Z

@smaheshm, what is the issue here?

BGP GR livelock test fails due to veth interface is in 'DOWN' state.

For some reason 'veth' I/F (eth1, eth2) goes down once the docker VS comes up. This doesn't happen in earlier release.

There's a netlink down event generated for eth1 (and eth2) once VS image comes up but I don't see the any message in syslog to shut down the eth1 I/F.

Added an explicit i/f up command in the BGP GR livelock test.

rlhui · 2020-05-28T19:21:35Z

@lguohan , @abdosi , please help review this PR? Thanks.

abdosi

@smaheshm, what is the issue here?

BGP GR livelock test fails due to veth interface is in 'DOWN' state.

For some reason 'veth' I/F (eth1, eth2) goes down once the docker VS comes up. This doesn't happen in earlier release.

There's a netlink down event generated for eth1 (and eth2) once VS image comes up but I don't see the any message in syslog to shut down the eth1 I/F.

Added an explicit i/f up command in the BGP GR livelock test.

@kcudnik is this happening because of some change in vslib/src/SwitchStateBaseHostif.cpp.
There is some change in logic of ifup.

Can you check.

abdosi · 2020-05-28T19:36:38Z

platform/vs/tests/bgp/test_invalid_nexthop.py

@@ -15,6 +15,8 @@ def test_InvalidNexthop(dvs, testlog):
    dvs.servers[0].runcmd("ip addr add fc00::2/126 dev eth0")
    dvs.servers[0].runcmd("ifconfig eth0 up")

+    dvs.runcmd("ip link set dev eth1 up")
+    dvs.runcmd("ip link set dev eth2 up")


is this happening because of change in vslib/src/SwitchStateBaseHostif.cpp ? I see this file has some change in logic

@abdosi is correct. this is due to this pr. sonic-net/sonic-sairedis@0b43cab

should do something similiar to this. sonic-net/sonic-swss@aa116f4

the correct fix should be line 13 should be changed.

@smaheshm , what's the resolution of this? Are these comments fully resolved? Thanks.

@kcudnik, did you get a chance to check this one? Thanks.

abdosi · 2020-05-28T19:36:52Z

platform/vs/tests/bgp/test_no_export.py

@@ -20,6 +20,8 @@ def test_bounce(dvs, testlog):
    dvs.servers[1].runcmd("ip addr add 10.0.0.3/31 dev eth0")
    dvs.servers[1].runcmd("ifconfig eth0 up")

+    dvs.runcmd("ip link set dev eth1 up")
+    dvs.runcmd("ip link set dev eth2 up")


same as above.

lguohan · 2020-05-29T10:48:53Z

who is going to fix the mellanox build issue?

Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>

[Mellanox] Update SAI (release:v1.16.3.2; API:v1.6)

…o undid the previous change'

smaheshm · 2020-05-29T20:04:50Z

retest vsimage please

smaheshm · 2020-05-29T23:40:17Z

retest vsimage please

lguohan · 2020-05-29T23:51:42Z

can you update your commit message to list all the commit message for the submodule update?

lguohan · 2020-05-30T21:45:25Z

frankly speaking, the commit message in the pr fb6916f is really confusing, lots of useless immediate information. Please be careful about the commit message. You need to craft a clear commit message when you merge it.

smaheshm · 2020-06-02T00:27:25Z

frankly speaking, the commit message in the pr fb6916f is really confusing, lots of useless immediate information. Please be careful about the commit message. You need to craft a clear commit message when you merge it.

Got it, will edit the commit message before merging.

smaheshm and others added 9 commits May 6, 2020 03:19

Update sonic-sairedis (sairedis with SAI 1.6 headers)

5b5d1a1

Merge remote-tracking branch 'upstream/master'

4dd0ac5

Update SAIBCM to 3.7.4.2, which is built upon SAI1.6 headers

6b5acc3

missed updating BRCM_SAI variable, fixed it

b0899a4

Update SAIBCM to 3.7.4.2, updated link to libsaibcm

b849ab2

[Mellanox] Update SAI (release:v1.16.3; API:v1.6)

138bb7b

Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>

Merge pull request #2 from volodymyrsamotiy/202006_sai1.6

af50315

[Mellanox] Update SAI (release:v1.16.3; API:v1.6)

Merge Mellanox changes (SAI1.6 update) from master

60552d0

Update sonic-sairedis pointer to include SAI1.6 headers

9f84c96

smaheshm and others added 4 commits May 15, 2020 01:14

Merge remote-tracking branch 'upstream/master'

f2a4a79

[Mellanox] Update SDK to 4.4.0914 and FW to xx.2007.1112 to match SAI…

093ed9d

… 1.16.3 (API:v1.6) Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>

Merge pull request #3 from volodymyrsamotiy/202006_sai1.6

69a8628

[Mellanox] Update SDK to 4.4.0914 and FW to xx.2007.1112 to match SAI…

Merge remote-tracking branch 'upstream/master'

9155bfc

Merge remote-tracking branch 'upstream/master'

448b7bb

smaheshm added 2 commits May 27, 2020 23:40

ensure the veth link is up in docker VS container

7a91d7f

Merge remote-tracking branch 'upstream/master'

8744234

smaheshm added 2 commits May 28, 2020 03:22

Merge remote-tracking branch 'upstream/master'

8a3fd88

ensure the veth link is up in docker VS container

ddd55c0

abdosi reviewed May 28, 2020

View reviewed changes

Volodymyr Samotiy and others added 5 commits May 29, 2020 15:07

[Mellanox] Update SAI (release:v1.16.3.2; API:v1.6)

c17f22a

Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>

Merge pull request #4 from volodymyrsamotiy/202006_sai1.6

ea02427

[Mellanox] Update SAI (release:v1.16.3.2; API:v1.6)

use 'config interface startup' instead of using ifconfig command, als…

c7f479f

…o undid the previous change'

Merge branch 'master' of github.com:smaheshm/sonic-buildimage

23ac34e

Merge remote-tracking branch 'upstream/master'

b824559

abdosi approved these changes May 30, 2020

View reviewed changes

smaheshm merged commit fb6916f into sonic-net:master May 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update packages and pointers to use SAI1.6 headers. #4597

Update packages and pointers to use SAI1.6 headers. #4597

smaheshm commented May 14, 2020 •

edited

Loading

lguohan commented May 14, 2020

smaheshm commented May 14, 2020

akokhan commented May 20, 2020

akokhan commented May 20, 2020

lguohan commented May 21, 2020

akokhan commented May 22, 2020

akokhan commented May 22, 2020

lguohan commented May 27, 2020

smaheshm commented May 27, 2020

rlhui commented May 28, 2020

abdosi left a comment

abdosi May 28, 2020

lguohan May 29, 2020

lguohan May 29, 2020

lguohan May 29, 2020

rlhui May 30, 2020

rlhui May 30, 2020

abdosi May 28, 2020

lguohan commented May 29, 2020

smaheshm commented May 29, 2020

smaheshm commented May 29, 2020

lguohan commented May 29, 2020

lguohan commented May 30, 2020

smaheshm commented Jun 2, 2020

Update packages and pointers to use SAI1.6 headers. #4597

Update packages and pointers to use SAI1.6 headers. #4597

Conversation

smaheshm commented May 14, 2020 • edited Loading

lguohan commented May 14, 2020

smaheshm commented May 14, 2020

akokhan commented May 20, 2020

akokhan commented May 20, 2020

lguohan commented May 21, 2020

akokhan commented May 22, 2020

akokhan commented May 22, 2020

lguohan commented May 27, 2020

smaheshm commented May 27, 2020

rlhui commented May 28, 2020

abdosi left a comment

Choose a reason for hiding this comment

abdosi May 28, 2020

Choose a reason for hiding this comment

lguohan May 29, 2020

Choose a reason for hiding this comment

lguohan May 29, 2020

Choose a reason for hiding this comment

lguohan May 29, 2020

Choose a reason for hiding this comment

rlhui May 30, 2020

Choose a reason for hiding this comment

rlhui May 30, 2020

Choose a reason for hiding this comment

abdosi May 28, 2020

Choose a reason for hiding this comment

lguohan commented May 29, 2020

smaheshm commented May 29, 2020

smaheshm commented May 29, 2020

lguohan commented May 29, 2020

lguohan commented May 30, 2020

smaheshm commented Jun 2, 2020

smaheshm commented May 14, 2020 •

edited

Loading