Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frr/ruijie] fix #4733 Add support for BGP_ROUTEMAPS #4955

Closed
wants to merge 1 commit into from

Conversation

tim-rj
Copy link
Contributor

@tim-rj tim-rj commented Jul 13, 2020

Signed-off-by: tim-rj sonic_rd@ruijie.com.cn

- Why I did it
BGP_ROUTEMAPS is not translated into FRR configuration
- How I did it
Add support for BGP_ROUTEMAPS & BGP_PEER_RANGE
- How to verify it
Check BGP_ROUTEMAPS configuration via show route-map
- Description for the changelog

root@switch2:/home/admin# show route-map
ZEBRA:
...
route-map: From-LC Invoked: 0
 permit, sequence 5 Invoked 0
  Match clauses:
    community 20
  Set clauses:
  Call clause:
  Action:
    Exit routemap
route-map: SetComm-1/1 Invoked: 0
 permit, sequence 5 Invoked 0
  Match clauses:
  Set clauses:
    community 1:1
    metric 1000
  Call clause:
  Action:
    Exit routemap
route-map: SetComm-1/2 Invoked: 0
 permit, sequence 5 Invoked 0
  Match clauses:
  Set clauses:
    community 1:2
    metric 1000
  Call clause:
  Action:
    Exit routemap
route-map: SetComm-1/4 Invoked: 0
 permit, sequence 5 Invoked 0
  Match clauses:
  Set clauses:
    community 1:4
    metric 1000
  Call clause:
  Action:
    Exit routemap
route-map: SetComm-HostRoute Invoked: 0
 permit, sequence 5 Invoked 0
  Match clauses:
  Set clauses:
    community 1:8005
    metric 1000
  Call clause:
  Action:
    Exit routemap
route-map: To-LC Invoked: 0
 permit, sequence 5 Invoked 0
  Match clauses:
    community 10
  Set clauses:
  Call clause:
  Action:
    Exit routemap

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: tim-rj <sonic_rd@ruijie.com.cn>
@pavel-shirshov pavel-shirshov self-requested a review July 14, 2020 16:46
@pavel-shirshov pavel-shirshov self-assigned this Jul 14, 2020
@pavel-shirshov
Copy link
Contributor

It is supported here: https://github.com/Azure/sonic-buildimage/tree/master/dockers/docker-fpm-frr/frr/bgpd/templates Please look inside of the directories. Ask me here, if you have more questions.

@tim-rj
Copy link
Contributor Author

tim-rj commented Jul 15, 2020

It is supported here: https://github.com/Azure/sonic-buildimage/tree/master/dockers/docker-fpm-frr/frr/bgpd/templates Please look inside of the directories. Ask me here, if you have more questions.

hi pavel, please check #4733, we can't find keywords BGP_ROUTEMAPS in sonic-swss/doc/Configuration.md(Only BGP_NEIGHBOR & BGP_PEER_RANGE found), right?

@tim-rj tim-rj changed the title [frr/ruijie] fix #4733 Add support for BGP_ROUTEMAPS & BGP_PEER_RANGE [frr/ruijie] fix #4733 Add support for BGP_ROUTEMAPS Jul 15, 2020
@pavel-shirshov
Copy link
Contributor

Hi @tim-rj Yes, you're right this is not supported. But we have this proposal sonic-net/SONiC#544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants