Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic-platform-common] Update submodule #5625

Merged
merged 3 commits into from
Oct 16, 2020
Merged

[sonic-platform-common] Update submodule #5625

merged 3 commits into from
Oct 16, 2020

Conversation

jleveque
Copy link
Contributor

@jleveque jleveque commented Oct 14, 2020

Includes the following commits:

vdahiya12
vdahiya12 previously approved these changes Oct 15, 2020
@jleveque
Copy link
Contributor Author

Retest mellanox please

@vdahiya12
Copy link
Contributor

Retest mellanox please

@jleveque jleveque merged commit d8363a9 into sonic-net:master Oct 16, 2020
@jleveque jleveque deleted the update_plat_comm branch October 16, 2020 18:17
jleveque added a commit that referenced this pull request Oct 18, 2020
… in Chassis class (#5649)

The `get_serial_number()` method in the ChassisBase and ModuleBase classes was redundant, as the `get_serial()` method is inherited from the DeviceBase class. This method was removed from the base classes in sonic-platform-common and the submodule was updated in #5625.

This PR aligns the existing vendor platform API implementations to remove the `get_serial_number()` methods and ensure the `get_serial()` methods are implemented, if they weren't previously.

Note that this PR does not modify the Dell platform API implementations, as this will be handled as part of #5609
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
Includes the following commits:

* src/sonic-platform-common 111dcf7...b316f8d (5):
  > [sonic_platform_base] fix an indentation in fan_drawer_base.py (sonic-net#133)
  > [SONIC_Y_CABLE] Adding new Y cable Package for accessing  Y cable QSFP's eeprom and configuring Y cable's mux through eeprom (sonic-net#128)
  > Merge pull request sonic-net#132 from vdahiya12/adding_changes_for_base_api
  > [ChassisBase][ModuleBase] Remove redundant 'get_serial_number()' method (sonic-net#130)
  > Merge pull request sonic-net#125 from vdahiya12/changes_for_mux_driver
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
… in Chassis class (sonic-net#5649)

The `get_serial_number()` method in the ChassisBase and ModuleBase classes was redundant, as the `get_serial()` method is inherited from the DeviceBase class. This method was removed from the base classes in sonic-platform-common and the submodule was updated in sonic-net#5625.

This PR aligns the existing vendor platform API implementations to remove the `get_serial_number()` methods and ensure the `get_serial()` methods are implemented, if they weren't previously.

Note that this PR does not modify the Dell platform API implementations, as this will be handled as part of sonic-net#5609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants