Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snmpagent] update submodule #6169

Merged
merged 5 commits into from
Jan 14, 2021

Conversation

stepanblyschak
Copy link
Collaborator

@stepanblyschak stepanblyschak commented Dec 9, 2020

Includes below sonic-snmpagent commits

dfde06e 2021-01-13 | Revert "[rfc1213] Interface MIB add l3 vlan interfaces & aggregate rif counters (#169)" (#191) [Stepan Blyshchak]
45edd7e 2021-01-04 | [snmpagent] Fix hardcoded qsfp lane count by reading sensor status from DB (#184) [Junchao-Mellanox]
3b72a6f 2021-01-02 | Fix: handle empty LOC_CHASSIS_TABLE (#190) [Qi Luo]
4aad821 2020-12-29 | [sysName]: Implement sysName OID (#185) [SuvarnaMeenakshi]
8efb4bb 2020-12-29 | [rfc1213] fix counter value type (#189) [Stepan Blyshchak]
025483a 2020-12-23 | [RouteUpdater]: Fix multi_asic mock function implementation and multi_asic variable name (#186) [SuvarnaMeenakshi]
381ae47 2020-12-10 | [mibs] b'VLAN_TABLE:' -> 'VLAN_TABLE' (#181) [Stepan Blyshchak]
e54036c 2020-12-09 | [rfc1213] Interface MIB add l3 vlan interfaces & aggregate rif counters (#169) [Stepan Blyshchak]
fd1eae7 2020-11-24 | Set swsscommon logging level (#178) [Qi Luo]
706d504 2020-11-23 | Improve MockRedis _encode(): so it will work on all types of value (#179) [Qi Luo]
64c93a1 2020-11-16 | [RFC4292][Namespace]: Fix implementation of RouteUpdater for multi-asic platform (#176) [SuvarnaMeenakshi]
b8f19ee 2020-11-12 | [sonic-snmpagent] SONiC physical entity mib extension (#168) [Junchao-Mellanox]
6b94ec3 2020-11-05 | Replace swsssdk.SonicV2Connector with swsscommon.SonicV2Connector (SWIG wrapper of C++ implementation) in production code (#162) [Qi Luo]

- Why I did it

- How I did it

- How to verify it

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

e54036c (HEAD, origin/master, origin/HEAD, master) [rfc1213] Interface MIB add l3 vlan interfaces & aggregate rif counters (sonic-net#169)
fd1eae7 Set swsscommon logging level (sonic-net#178)
706d504 Improve MockRedis _encode(): so it will work on all types of value (sonic-net#179)
64c93a1 [RFC4292][Namespace]: Fix implementation of RouteUpdater for multi-asic platform (sonic-net#176)
b8f19ee [sonic-snmpagent] SONiC physical entity mib extension (sonic-net#168)
6b94ec3 Replace swsssdk.SonicV2Connector with swsscommon.SonicV2Connector (SWIG wrapper of C++ implementation) in production code (sonic-net#162)

Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
@stepanblyschak
Copy link
Collaborator Author

Looking at the VS test failure

@stepanblyschak
Copy link
Collaborator Author

@qiluo-msft Looks like swsscommon SonicV2Connector is missing pubsub interface:

Dec 10 11:22:52.244611 r-tigon-11 ERR snmp#snmp-subagent [ax_interface] ERROR: MIBUpdater.start() caught an unexpected exception during update_data()#012Traceback (most recent call last):#012  File "/usr/local/lib/python3.7/dist-packages/ax_interface/mib.py", line 43, in start#012    self.update_data()#012  File "/usr/local/lib/python3.7/dist-packages/sonic_ax_impl/mibs/ieee802_1ab.py", line 560, in update_data#012    self.pubsub[i] = mibs.get_redis_pubsub(self.db_conn[i], self.db_conn[i].APPL_DB, pattern)#012  File "/usr/local/lib/python3.7/dist-packages/sonic_ax_impl/mibs/__init__.py", line 477, in get_redis_pubsub#012    pubsub = redis_client.pubsub()#012  File "/usr/lib/python3/dist-packages/swsscommon/swsscommon.py", line 1076, in <lambda>#012    __getattr__ = lambda self, name: _swig_getattr(self, DBConnector, name)#012  File "/usr/lib/python3/dist-packages/swsscommon/swsscommon.py", line 80, in _swig_getattr#012    raise AttributeError("'%s' object has no attribute '%s'" % (class_type.__name__, name))#012AttributeError: 'DBConnector' object has no attribute 'pubsub'

Could you please help to resolve this issue?

Also, could you please look at small fixup of sonic-net/sonic-snmpagent#181?

@qiluo-msft
Copy link
Collaborator

Ack

@qiluo-msft
Copy link
Collaborator

It should be fixed in #6197

@qiluo-msft
Copy link
Collaborator

Retest this please

Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
@stepanblyschak
Copy link
Collaborator Author

retest this please

1 similar comment
@stepanblyschak
Copy link
Collaborator Author

retest this please

@lguohan
Copy link
Collaborator

lguohan commented Dec 24, 2020

retest vsimage please

@lguohan lguohan linked an issue Dec 24, 2020 that may be closed by this pull request
@lguohan
Copy link
Collaborator

lguohan commented Dec 24, 2020

retest vsimage please

@lguohan
Copy link
Collaborator

lguohan commented Dec 25, 2020

@qiluo-msft, loosk like is failing, is there a regression in this submodule update?

snmp.test_snmp_pfc_counters.test_snmp_pfc_counters

@qiluo-msft
Copy link
Collaborator

We are working on it, there is at least one known issue.

@qiluo-msft
Copy link
Collaborator

Retest mellanox please

@lguohan
Copy link
Collaborator

lguohan commented Jan 1, 2021

retest vsimage please

@lguohan
Copy link
Collaborator

lguohan commented Jan 3, 2021

the test is still failing? can you folks check?

@lguohan
Copy link
Collaborator

lguohan commented Jan 4, 2021

@stepanblyschak , @qiluo-msft , where are we on this pr?

@lguohan
Copy link
Collaborator

lguohan commented Jan 5, 2021

retest vsimage please

@stepanblyschak
Copy link
Collaborator Author

@qiluo-msft The test fails because the test gets the interfaces from rfc1213 MIB and description from rfc2863 MIB. Since Vlan has been added to rfc1213 only it fails to get "description". I'm modifying test to work without required 'description'.

@stepanblyschak
Copy link
Collaborator Author

@qiluo-msft Could you please check sonic-net/sonic-mgmt#2782?

@qiluo-msft
Copy link
Collaborator

qiluo-msft commented Jan 8, 2021

@stepanblyschak, this is not a test issue, but a code issue inside snmpagent. The interfaces in rfc1213 MIB and rfc2863 MIB should be consistent. For this case, you need to add the 'Description' (and also other fields?) to rfc2863, even an empty string is better than nothing.

@lguohan lguohan merged commit 9a1b42f into sonic-net:master Jan 14, 2021
lguohan pushed a commit that referenced this pull request Jan 15, 2021
Includes below sonic-snmpagent commits
```
dfde06e 2021-01-13 | Revert "[rfc1213] Interface MIB add l3 vlan interfaces & aggregate rif counters (#169)" (#191) [Stepan Blyshchak]
45edd7e 2021-01-04 | [snmpagent] Fix hardcoded qsfp lane count by reading sensor status from DB (#184) [Junchao-Mellanox]
3b72a6f 2021-01-02 | Fix: handle empty LOC_CHASSIS_TABLE (#190) [Qi Luo]
4aad821 2020-12-29 | [sysName]: Implement sysName OID (#185) [SuvarnaMeenakshi]
8efb4bb 2020-12-29 | [rfc1213] fix counter value type (#189) [Stepan Blyshchak]
025483a 2020-12-23 | [RouteUpdater]: Fix multi_asic mock function implementation and multi_asic variable name (#186) [SuvarnaMeenakshi]
381ae47 2020-12-10 | [mibs] b'VLAN_TABLE:' -> 'VLAN_TABLE' (#181) [Stepan Blyshchak]
e54036c 2020-12-09 | [rfc1213] Interface MIB add l3 vlan interfaces & aggregate rif counters (#169) [Stepan Blyshchak]
fd1eae7 2020-11-24 | Set swsscommon logging level (#178) [Qi Luo]
706d504 2020-11-23 | Improve MockRedis _encode(): so it will work on all types of value (#179) [Qi Luo]
64c93a1 2020-11-16 | [RFC4292][Namespace]: Fix implementation of RouteUpdater for multi-asic platform (#176) [SuvarnaMeenakshi]
b8f19ee 2020-11-12 | [sonic-snmpagent] SONiC physical entity mib extension (#168) [Junchao-Mellanox]
6b94ec3 2020-11-05 | Replace swsssdk.SonicV2Connector with swsscommon.SonicV2Connector (SWIG wrapper of C++ implementation) in production code (#162) [Qi Luo]
```

Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
Co-authored-by: Qi Luo <qiluo-msft@users.noreply.github.com>
@stepanblyschak stepanblyschak deleted the update_snmp_pointer branch September 23, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

physical entity data missing from SNMP
3 participants