Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DHCP Relay]: Now listen on all front panel, VLAN and PortChannel interfaces with IPv4 addresses #645

Merged
merged 2 commits into from
May 31, 2017
Merged

[DHCP Relay]: Now listen on all front panel, VLAN and PortChannel interfaces with IPv4 addresses #645

merged 2 commits into from
May 31, 2017

Conversation

jleveque
Copy link
Contributor

  • isc-dhcp-relay must be configured to listen on all client-facing and server-facing interfaces. This is not explicitly mentioned in the documentation.

@jleveque jleveque self-assigned this May 30, 2017
@jleveque jleveque requested a review from lguohan May 30, 2017 19:24
@stcheng
Copy link
Contributor

stcheng commented May 30, 2017

i'd recommend to add a sample output file in sonic-config-engine tests folder.

@jleveque
Copy link
Contributor Author

Sample output file added.

@stcheng stcheng merged commit b8c11bc into sonic-net:master May 31, 2017
@jleveque jleveque deleted the dhcp_relay_fix branch May 31, 2017 04:30
lguohan added a commit to lguohan/sonic-buildimage that referenced this pull request Oct 24, 2018
@lguohan
[submodule]: update sonic-swss
5670015 
* 6e76e9b 2018-10-22 | [vstest]: fix redis mount point with --dvsname option (sonic-net#654) (HEAD, origin/master, origin/HEAD) [lguohan]
* 3d4bed1 2018-10-22 | [mirrororch]: Fix bug when no need to update session type (sonic-net#648) [Shuotian Cheng]
*   4bf28ed 2018-10-22 | Merge pull request sonic-net#649 from lguohan/vstest [lguohan]
|\
| * 8620a51 2018-10-22 | [vstest]: disable ipv6 in test_crm.py::test_CrmFdbEntry [Guohan Lu]
| * f684d65 2018-10-21 | change mode to 644 for test_setro.py [Guohan Lu]
| * 51e0d40 2018-10-22 | Enable aclfield.data for SAI_DTEL_ATTR_INT_L4_DSCP [Guohan Lu]
| * 9290950 2018-10-21 | use unique directory to mount redis.sock [Guohan Lu]
| * 7d1b09e 2018-10-21 | add --keeptb option to keep testbed after test [Guohan Lu]
| * 6ee779c 2018-10-22 | gather logs from vs container [Guohan Lu]
| * 9b49555 2018-10-21 | make sure delete the srv namespace after test [Guohan Lu]
| * e04bd2d 2018-10-20 | add testlog for all tests [Guohan Lu]
| * a2d9be4 2018-10-20 | simplify start_swss/stop_swss [Guohan Lu]
| * d76a560 2018-10-21 | add ingore object type to CountSubscribedObjects [Guohan Lu]
| * 5e2c1de 2018-10-20 | refactor test_swss_neighbor_syncup test [Guohan Lu]
| * 9e9a553 2018-10-20 | ensure vrfmgrd, teammgrd, portmgrd are running before test [Guohan Lu]
|/
* e8e3ddc 2018-10-21 | disable ipv6 for vEthernet interface in virtual switch (sonic-net#650) [lguohan]
* 7c90bb3 2018-10-19 | Fix portorch bake: get port count from db (sonic-net#645) [Qi Luo]

Signed-off-by: Guohan Lu <gulv@microsoft.com>
@lguohan lguohan mentioned this pull request Oct 24, 2018
Merged
lguohan added a commit that referenced this pull request Oct 25, 2018
@lguohan
[submodule]: update sonic-swss (#2190)
c3c6de4 
* 6e76e9b 2018-10-22 | [vstest]: fix redis mount point with --dvsname option (#654) (HEAD, origin/master, origin/HEAD) [lguohan]
* 3d4bed1 2018-10-22 | [mirrororch]: Fix bug when no need to update session type (#648) [Shuotian Cheng]
*   4bf28ed 2018-10-22 | Merge pull request #649 from lguohan/vstest [lguohan]
|\
| * 8620a51 2018-10-22 | [vstest]: disable ipv6 in test_crm.py::test_CrmFdbEntry [Guohan Lu]
| * f684d65 2018-10-21 | change mode to 644 for test_setro.py [Guohan Lu]
| * 51e0d40 2018-10-22 | Enable aclfield.data for SAI_DTEL_ATTR_INT_L4_DSCP [Guohan Lu]
| * 9290950 2018-10-21 | use unique directory to mount redis.sock [Guohan Lu]
| * 7d1b09e 2018-10-21 | add --keeptb option to keep testbed after test [Guohan Lu]
| * 6ee779c 2018-10-22 | gather logs from vs container [Guohan Lu]
| * 9b49555 2018-10-21 | make sure delete the srv namespace after test [Guohan Lu]
| * e04bd2d 2018-10-20 | add testlog for all tests [Guohan Lu]
| * a2d9be4 2018-10-20 | simplify start_swss/stop_swss [Guohan Lu]
| * d76a560 2018-10-21 | add ingore object type to CountSubscribedObjects [Guohan Lu]
| * 5e2c1de 2018-10-20 | refactor test_swss_neighbor_syncup test [Guohan Lu]
| * 9e9a553 2018-10-20 | ensure vrfmgrd, teammgrd, portmgrd are running before test [Guohan Lu]
|/
* e8e3ddc 2018-10-21 | disable ipv6 for vEthernet interface in virtual switch (#650) [lguohan]
* 7c90bb3 2018-10-19 | Fix portorch bake: get port count from db (#645) [Qi Luo]

Signed-off-by: Guohan Lu <gulv@microsoft.com>
@abdosi abdosi mentioned this pull request Feb 21, 2020
Merged
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020
@qiluo-msft
Fix portorch bake: get port count from db (sonic-net#645)
7c90bb3 
* Fix portorch bake: get port count from db
* Refine logging
gechiang added a commit that referenced this pull request Jul 28, 2020
@gechiang
[sonic-sairedis] Update Submodule (#5052)
cdc6521 
Advanced Submodule head of Sonic-Sairedis and picked up the following changes:

Workaround getSwitchType failure due to NPU SAI not yet supporting it (#647)
sonic-net/sonic-sairedis#647

Adding support for new SAI API sai_query_attribute_capability() (#645)
sonic-net/sonic-sairedis#645

[syncd] ARM32 bit fixes, for 64bit printf format specifier. (#643)  
Signed-off-by: Rajkumar Pennadam Ramamoorthy <rpennadamram@marvell.com>
sonic-net/sonic-sairedis#643

[syncd] Add support for synchronous bulk api (#640)
sonic-net/sonic-sairedis#640
dmytroxshevchuk pushed a commit to dmytroxshevchuk/sonic-buildimage that referenced this pull request Aug 31, 2020
@gechiang
Adding support for new SAI API sai_query_attribute_capability() (soni…
4a3a568 
…c-net#645)

* Addind support for new SAI API sai_query_attribute_capability()
dmytroxshevchuk pushed a commit to dmytroxshevchuk/sonic-buildimage that referenced this pull request Aug 31, 2020
@gechiang
Re-enable support for new SAI API sai_query_attribute_capability() (s…
276b9ae 
…onic-net#651)

Previously the code to support query SAI attribute capabilities were commented out due to discovered missing BRCM Vendor SAI API missing in their 3.7.5.1 debian package that caused linking error during image build.
See sonic-net#645 for details on the SAI attribute capability query support.

Since BRCM has provided the patch for the missing API stub code and included them in BRCM SAI 3.7.5.1-2 (see sonic-net#5101), I am raising this PR to re-enable the calling to Vendor SAI API sai_query_attribute_capability().

I have tested this with the new BRCM SAI 3.7.5.1-2 debians and ensured that the linking issue was fixed by that patch.
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 10, 2021
@lguohan
Changes in swss-utilities submodule to support NAT feature. (sonic-ne…
6b23f19 
…t#645)

Signed-off-by: akhilesh.samineni@broadcom.com
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Jul 22, 2022
@yxieca
[202205][sairedis][platform-daemon][linkmgrd][utilities][swss-common]…
34456b2 
… advance submodule head

sairedis:
* 38c0bb1 2022-07-21 | [sairedis] Fix reopen recoding file (sonic-net#1087) (HEAD -> 202205, github/202205) [Kamil Cudnik]

platform-daemon:
* 17587b6 2022-07-22 | [ycabled] add secure channel support for grpc dualtor active-active connectivity  (sonic-net#275) (HEAD -> 202205, github/202205) [vdahiya12]

linkmgrd:
* c911ec7 2022-07-21 | Avoid unnecessary error logs from `handleGetServerMacAddressNotification` (sonic-net#96) (HEAD -> 202205) [Jing Zhang]
* bbae81d 2022-07-18 | Add support for reconciliation after warm restart  (sonic-net#76) [Jing Zhang]

utilities:
* bcc1206 2022-07-20 | Change db_migrator major version on master branch from version 2 to 3 (sonic-net#2272) (HEAD -> 202205) [Vaibhav Hemant Dixit]
* ad40697 2022-07-21 | Fix test for pfcwd_sw_enable in db_migrator_test (sonic-net#2253) [bingwang-ms]
* 886f612 2022-07-22 | Revert "show commands for SYSTEM READY (sonic-net#1851) (sonic-net#2261)" (sonic-net#2274) (github/202205) [Ying Xie]
* a6404b7 2022-07-17 | show commands for SYSTEM READY (sonic-net#1851) (sonic-net#2261) [Senthil Kumar Guruswamy]

swss-common:
* 509b265 2022-07-06 | Add device global table definition (sonic-net#645) (HEAD -> 202205) [tjchadaga]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@yxieca yxieca mentioned this pull request Jul 22, 2022
Merged
yxieca added a commit that referenced this pull request Jul 23, 2022
@yxieca
[202205][sairedis][platform-daemon][linkmgrd][utilities][swss-common]…
f96f0e4 
… advance submodule head (#11518)

sairedis:
* 38c0bb1 2022-07-21 | [sairedis] Fix reopen recoding file (#1087) (HEAD -> 202205, github/202205) [Kamil Cudnik]

platform-daemon:
* 17587b6 2022-07-22 | [ycabled] add secure channel support for grpc dualtor active-active connectivity  (#275) (HEAD -> 202205, github/202205) [vdahiya12]

linkmgrd:
* c911ec7 2022-07-21 | Avoid unnecessary error logs from `handleGetServerMacAddressNotification` (#96) (HEAD -> 202205) [Jing Zhang]
* bbae81d 2022-07-18 | Add support for reconciliation after warm restart  (#76) [Jing Zhang]

utilities:
* bcc1206 2022-07-20 | Change db_migrator major version on master branch from version 2 to 3 (#2272) (HEAD -> 202205) [Vaibhav Hemant Dixit]
* ad40697 2022-07-21 | Fix test for pfcwd_sw_enable in db_migrator_test (#2253) [bingwang-ms]
* 886f612 2022-07-22 | Revert "show commands for SYSTEM READY (#1851) (#2261)" (#2274) (github/202205) [Ying Xie]
* a6404b7 2022-07-17 | show commands for SYSTEM READY (#1851) (#2261) [Senthil Kumar Guruswamy]

swss-common:
* 509b265 2022-07-06 | Add device global table definition (#645) (HEAD -> 202205) [tjchadaga]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
skbarista pushed a commit to skbarista/sonic-buildimage that referenced this pull request Aug 17, 2022
@yxieca @skbarista
[202205][sairedis][platform-daemon][linkmgrd][utilities][swss-common]…
5d98292 
… advance submodule head (sonic-net#11518)

sairedis:
* 38c0bb1 2022-07-21 | [sairedis] Fix reopen recoding file (sonic-net#1087) (HEAD -> 202205, github/202205) [Kamil Cudnik]

platform-daemon:
* 17587b6 2022-07-22 | [ycabled] add secure channel support for grpc dualtor active-active connectivity  (sonic-net#275) (HEAD -> 202205, github/202205) [vdahiya12]

linkmgrd:
* c911ec7 2022-07-21 | Avoid unnecessary error logs from `handleGetServerMacAddressNotification` (sonic-net#96) (HEAD -> 202205) [Jing Zhang]
* bbae81d 2022-07-18 | Add support for reconciliation after warm restart  (sonic-net#76) [Jing Zhang]

utilities:
* bcc1206 2022-07-20 | Change db_migrator major version on master branch from version 2 to 3 (sonic-net#2272) (HEAD -> 202205) [Vaibhav Hemant Dixit]
* ad40697 2022-07-21 | Fix test for pfcwd_sw_enable in db_migrator_test (sonic-net#2253) [bingwang-ms]
* 886f612 2022-07-22 | Revert "show commands for SYSTEM READY (sonic-net#1851) (sonic-net#2261)" (sonic-net#2274) (github/202205) [Ying Xie]
* a6404b7 2022-07-17 | show commands for SYSTEM READY (sonic-net#1851) (sonic-net#2261) [Senthil Kumar Guruswamy]

swss-common:
* 509b265 2022-07-06 | Add device global table definition (sonic-net#645) (HEAD -> 202205) [tjchadaga]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

@stcheng stcheng stcheng approved these changes

Assignees

@jleveque jleveque

Labels
Bug 🐛 DHCP Relay
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jleveque @stcheng @lguohan @msftclas