platform/broadcom: Add a new supported device and platform, AS7712-32X #662

pollyhsu2git · 2017-06-02T10:34:54Z

Switch Vendor: Edge-core
Switch SKU: AS7712-32X
ASIC Vendor: Broadcom
Swich ASIC: Tomahawk
Port Configuration: 32x100G
SONiC Image: SONiC-ONIE-Broadcom

Signed-off-by: polly_hsu@accton.com

* Switch Vendor: Edge-core * Switch SKU: AS7712-32X * ASIC Vendor: Broadcom * Swich ASIC: Tomahawk * Port Configuration: 32x100G * SONiC Image: SONiC-ONIE-Broadcom Signed-off-by: polly_hsu@accton.com

msftclas · 2017-06-02T10:35:01Z

@pollyhsu2git,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

lguohan · 2017-06-02T17:01:44Z

rules/config

@@ -30,7 +30,7 @@ SONIC_CONFIG_LOG_TO_FILES = y
 DEFAULT_USERNAME = admin

 # DEFAULT_PASSWORD - default password for installer build
-DEFAULT_PASSWORD = YourPaSsWoRd
+DEFAULT_PASSWORD = admin


this affect all platform, please do not change this.

lguohan,
Got it~ Could you help to discard the change of rules/config? Not sure how to do so upon the pull request.

lguohan · 2017-06-02T17:03:51Z

device/accton/x86_64-accton_as7712_32x-r0/AS7712-32X/port_config.ini

+Ethernet96      113,114,115,116       hundredGigE25
+#Ethernet100     117,118,119,120       hundredGigE26
+#Ethernet104     121,122,123,124       hundredGigE27
+#Ethernet108     125,126,127,128       hundredGigE28


why commented out these ports?

lguohan,
They were commented out due to the limitation of the maximum number of ports supported verified by Shuotian on our issue post of the sonicproject forum with the subject, Failed to open platform configuration file : /etc/bcm/th-as7712-32x100G.config.bcm dated 2017-05-16 https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!topic/sonicproject/NBTGLvxPnMM
They would be restored upon Shuotian's patch available

Hello, the patch is already checked in. Please test and reenable the ports.

stcheng,
Which Jenkins build with your patch checked-in? We'll test it with~

We can not test it with the current code compiled with errors

$ make configure PLATFORM=broadcom
$ make target/sonic-broadcom.bin
....
make[1]: Entering directory '/sonic/src/sonic-linux-kernel'
make[1]: *** No rule to make target '/sonic/target/debs/linux-headers-3.16.0-4-common_3.16.36-1+deb8u2_amd64.deb'. Stop.
make[1]: Leaving directory '/sonic/src/sonic-linux-kernel'
make: *** [target/debs/linux-headers-3.16.0-4-common_3.16.36-1+deb8u2_amd64.deb] Error 1
slave.mk:157: recipe for target 'target/debs/linux-headers-3.16.0-4-common_3.16.36-1+deb8u2_amd64.deb' failed
make: Leaving directory '/sonic'

Let's try to test it with the latest Jenkins build#224 here~

lguohan · 2017-06-02T17:10:05Z

dockers/docker-orchagent/orchagent.sh

@@ -30,6 +30,8 @@ elif [ "$HWSKU" == "INGRASYS-S8900-54XC" ]; then
    ORCHAGENT_ARGS+="-m $MAC_ADDRESS"
 elif [ "$HWSKU" == "INGRASYS-S8900-64XC" ]; then
    ORCHAGENT_ARGS+="-m $MAC_ADDRESS"
+elif [ "$HWSKU" == "AS7712-32X" ]; then


HWSKU follow name convention vendor-MODEL-portstype

In you case, it is Accton-AS7712-32X

stcheng · 2017-06-05T02:17:52Z

dockers/docker-orchagent/orchagent.sh

@@ -30,6 +30,8 @@ elif [ "$HWSKU" == "INGRASYS-S8900-54XC" ]; then
    ORCHAGENT_ARGS+="-m $MAC_ADDRESS"
 elif [ "$HWSKU" == "INGRASYS-S8900-64XC" ]; then
    ORCHAGENT_ARGS+="-m $MAC_ADDRESS"
+elif [ "$HWSKU" == "Accton-AS7712-32X" ]; then


could you resolve the conflicts here?

Yes. The name of the <HARDWARE_SKU> directory should match your $HWSKU exactly, which, in this case is Accton-AS7712-32X.

stcheng · 2017-06-05T02:19:23Z

Could you also update the HwSKU of AS7512 to have Accton prefix?

pollyhsu2git

Please help to review our changes upon reviewed

Change DEFAULT_USERNAME back to YourPaSsWoRd

* Re-enable the front port, 26 / 27 / 28 of `port_config.ini` and the SDK config file, `th-as7712-32x100G.config.bcm` upon tested OK on the Jenkins#224 * Re-name <HARDWARE_SKU> of Device-Specific Files as Accton-AS7712-32X after <HwSku> of minigraph.xml was requested changed. Signed-off-by: polly_hsu@accton.com

pollyhsu2git

[platform/broadcom]: Update Accton-AS7712-32X …
pollyhsu2git committed 7 minutes ago

Re-enable the front port, 26 / 27 / 28 of port_config.ini and the SDK config file, th-as7712-32x100G.config.bcm upon tested OK on the Jenkins#224
Re-name <HARDWARE_SKU> of Device-Specific Files as Accton-AS7712-32X after of minigraph.xml was requested changed.

stcheng · 2017-06-06T17:06:24Z

could you check the file in saibcm*.deb package or the file in docker-syncd /etc/bcm/README.msft to see if the config.bcm file follows our requirements and then send it to me directly? So we could embed the file into the saibcm*.deb package.

stcheng · 2017-06-06T17:07:26Z

device/accton/x86_64-accton_as7712_32x-r0/minigraph.xml

@@ -0,0 +1,75 @@
+<DeviceMiniGraph xmlns:i="http://www.w3.org/2001/XMLSchema-instance" xmlns="Microsoft.Search.Autopilot.Evolution">


No regular front panel interfaces in this minigraph file?

stcheng,
YES currently~ No regular front panel interfaces in our minigraph file.
We'll update it once we clarify your minigraph configuration model by more testing at our side.

that's fine.

stcheng · 2017-06-06T17:08:34Z

dockers/docker-orchagent/orchagent.sh

@@ -16,6 +16,11 @@ if [ "$ASIC" == "broadcom" ]; then
    ORCHAGENT_ARGS+="-m $MAC_ADDRESS"
 elif [ "$ASIC" == "cavium" ]; then
    ORCHAGENT_ARGS+="-m $MAC_ADDRESS"
+elif [ "$HWSKU" == "Accton-AS7712-32X" ]; then


you won't need to modify this file as it is trapped at "$ASIC" == "broadcom"

stcheng · 2017-06-06T17:14:34Z

platform/broadcom/platform-modules-accton.mk

@@ -0,0 +1,14 @@
+# Accton Platform modules


Is it better to have your own repository to put the platform modules? So that your platform modules code update could be independent to our repository. Similar to other platform modules.

Thanks for the suggestion~ We’ll enhance it upon the internal discussion about it~

* Modify `th-as7712-32x100G.config.bcm` based on config_checker; (Move not permitted: ccm_dma_enable / ccmdma_intr_enable / mem_cache_enable / dport_map_direct / dport_map_enable) Signed-off-by: polly_hsu@accton.com

* Undo the change of orchagent.sh upon reviewed Signed-off-by: polly_hsu@accton.com

pollyhsu2git

Modify th-as7712-32x100G.config.bcm based on config_checker (remove not permitted config: ccm_dma_enable / ccmdma_intr_enable / mem_cache_enable / dport_map_direct / dport_map_enable)
We've sent the config_checkered SDK config file, th-as7712-32x100G.config.bcm to Shuotian via hotmail for him to embed the file into the saibcm*.deb package
Undo the change of orchagent.sh upon reviewed

* Update `minigraph.xml` with the front panel interface configuration Signed-off-by: polly_hsu@accton.com

…/sonic-buildimage into platform-bcm-as7712

lguohan · 2017-06-07T17:32:08Z

platform/broadcom/sonic-platform-modules-accton/debian/platform-modules-as7712-32x.init

+    echo "done."
+    ;;
+
+stop)


this also needs to be implemented. as you can see the requirement here. https://github.com/Azure/SONiC/wiki/Porting%20Guide#platform-drivers

lguohan,
Thanks for the reminder~
We are aware of the peripheral part not done complete. We'll update it after our peripheral group examines / tests it further.

lguohan · 2017-06-07T17:34:33Z

platform/broadcom/sonic-platform-modules-accton/as7712-32x/cfg/th-as7712-32x100G.config.bcm

@@ -0,0 +1,295 @@
+# accton_as7710_32x 32x100G SDK config


this needs to go to saibcm debian package, and pass the attribute validation check. You can find the instructions for the validation check in the package.

lguohan,
Thanks for the reminder~
We sent our SDK config to stcheng for him to manage the saibcm debian packaging after we passed config_checker yesterday.

yes. I received it. please remove the file here. I will update the saibcm package.

stcheng, the removal was just done~

* Remove the SDK config, `th-as7712-32x100G.config.bcm` as it would be packed within saibcm deb package Signed-off-by: polly_hsu@accton.com

pollyhsu2git

Remove the SDK config, th-as7712-32x100G.config.bcm as it would be packed within saibcm deb package

* Remove the installation of the SDK config, `th-as7712-32x100G.config.bcm` as it would be packed within saibcm deb package Signed-off-by: polly_hsu@accton.com

pollyhsu2git

Remove the installation of the SDK config, th-as7712-32x100G.config.bcm as it would be packed within saibcm deb package

lguohan

still a few issues in the code review, leave them for future CR for now.

pollyhsu2git · 2017-06-15T01:55:06Z

@stcheng, we still see you high-lighting requested changes? Any requested changes we haven't resolved? Our customers been been asking when they can git pull AS7712-32X from here~

stcheng · 2017-06-15T02:23:28Z

@pollyhsu2git Just updated this. I will merge it tonight.

* [build_debian]: Add dbus package to update timezone (#702) Signed-off-by: Hiayang Zheng haiyang.z@alibaba.inc * [Accton]: Add a new supported device and platform, AS7712-32X (#662) * platform/broadcom: Add a new supported device and platform, AS7712-32X * Switch Vendor: Edge-core * Switch SKU: AS7712-32X * ASIC Vendor: Broadcom * Swich ASIC: Tomahawk * Port Configuration: 32x100G * SONiC Image: SONiC-ONIE-Broadcom Signed-off-by: polly_hsu@accton.com * [image]: load platform specific settings in sonic-to-sonic upgrade (#710) * [submodule]: Update sairedis submodule (#712) Include fix for saithrift port split parsing * [docker-ptf]: Install exabgp in docker ptf (#709) * [platform]: fix file mode for acction platform to create clean build (#714) * [image]: expand dockerfs.tar.gz directly on to disk without intermediate file (#715) * [submodule]: update swss/sairedis/swss-common submodule (#716) fix bug for logrotate sairedis log * [submodule]: update sonic-swss (#719) * [image]: add debian security update in the apt source list (#724) * [submodule]: update sonic-platform-daemons (#722) * [platform]: turn on/off four leds for breakout-able front panel ports (#723) turn on/off four leds for breakout-able front panel ports on arista 7050 qx32 platform * [sonic-quagga]:update submodule (#718) Signed-off-by: Sihui Han <sihan@microsoft.com> * Add Broadcom LED microprocessor initialization for Dell S6000 (#726) * Add Broadcom LED microprocessor initialization for Dell S6000 * Increase bcmcmd timeout to 60 seconds * [platform]: Update sonic-platform-modules-arista (#727) * [Broadcom]: Update SAI package to support Accton-AS7712-C32 (#720) * Remove exsiting sonic-platform-modules-accton and apply submodule add… (#717) * Remove exsiting sonic-platform-modules-accton and apply submodule adding on this folder. * Remove redundant commnet * Remove folder platform/broadcom/sonic-platform-modules-accton. * Add this dir for submodule. * [submodule]: update sonic-platform-daemons submodule (#731) * [installer] Copy old config files rather than only minigraph (#730) * [BGPD]: add bgp dynamic neighbor configuration (#708) * add bgp dynamic neighbor configuration * [bgpd]: update as comments * update as comment * update to deployment_id_asn_map * minor change * [docker-syncd-brcm]: Sleep to allow syncd to create socket before calling bcmcmd (#733) * [docker-syncd-brcm]: Sleep to allow syncd to create socket before calling bcmcmd * Instead of fixed sleep interval, continually check for presence of socket * [sonic-cfggen]: Support multiple input yaml files with -y option (#729) * [sonic-cfggen]: Fix minigraph.py when port_alias_map absent (#738) * [bgp]: move allowas-in into ipv6 section to enable allowas-in for ipv6 (#741) * [swss]: Sleep 5 min regardless of arp_update return code (#743) - arp_update return code is not guaranteed to be true/false. When there is no VLAN, arp_update will return true. When there are VLANs, arp_update will return false because the command arping returns 1 due to the option '-w 0'. - This script should be run every 5 minutes regardless of the return code. * [Mellanox]: Update SAI version (#740) - Initialize ECMP default hashing with IPv6 packets * [sonic-cfggen]: Add default IP deny rule in translate_acl (#734) - Add IPv4 implicit rule: deny ip any any This implicit rule has lowest priority and ensures that the device denies all unmatched IP traffic. * [docker-platform-monitor]: Add fancontrol (#735) * Fix typo in README (#750) * Fix typo in README * Fix comment * Fix README * [DHCP Relay]: Add support for custom Option 82 circuit_id of the form '<hostname>:<portname>' (#747) * Add docker-dhcp-relay/Dockerfile to .gitignore * Add isc-dhcp-relay .deb package to image build process, along with my Option 82 patch * Install custom isc-dhcp-relay in dhcp_relay docker * Install isc-dhcp-relay build dependencies in sonic-slave Docker container * Copy the built .deb package to the destination directory * Add dependencies for isc-dhcp-relay * Change Option 82 string to '<hostname>:<portname>' * Install dependencies of .deb files implicitly in Dockerfile * Remove unused line * Remove unnecessary space * [Accton]: Add a new supported device and platform AS7716-32X (#732) Switch Vendor: Edge-core Switch SKU: AS7716-32X ASIC Vendor: Broadcom Swich ASIC: Tomahawk Port Configuration: 32x100G SONiC Image: SONiC-ONIE-Broadcom Signed-off-by: polly_hsu@accton.com * [.gitignore]: Update src, config engine (#754) Signed-off-by: marian-pritsak <marianp@mellanox.com> * [submodule]: update sonic-swss (#755) * [sonic-swss-common]: Submodule update (#759) * [mgmt slave] Install correct version of python-cffi (#760) * [DHCP Relay]: Fix Option 82 string - Remove quotes; add MAC address of receiving port as remote_id (#763) * [platform]: add front panel index in port_config.ini for s6100 (#752) * add front panel index in port_config.ini * [igb]: change download url to azure storage url (#770) * [baseimage]: Increase net.core.rmem_max to 2097152 (#767) * Increase net.core.rmem_max to 2097152 * Update Ingrasys platform submodule (#764) * Remove specific fancontrol service. Signed-off-by: Wade He <chihen.he@gmail.com> * [Broadcom]: Update SAI package to support Celestica Seastone DX010 and Accton AS7716 (#768) * [LLDP]: Port description (TLV 4) now contains '<neighbor_host_name>:<port_name>' (#772) * [sonic-slave]: install docker-ce 17.03.02 stable version (#774) * [device]: add minigraph and LED support for Arista 7050 QX32S (#773) * Update submodules: sairedis, swss

swss: * 863b69c 2018-11-01 | [teamsyncd]: Fix bug when removing selectable in select function (sonic-net#665) (HEAD, origin/master, origin/HEAD) [Shuotian Cheng] * 2c83b68 2018-10-31 | Warm reboot: bring up ports for whole system warm reboot (sonic-net#653) [Qi Luo] * d049d65 2018-10-31 | [vstest]: get subscribed objects from appdb and asicdb (sonic-net#664) [lguohan] * 057a329 2018-10-31 | [vstest]: change the redis mount point when --dvsname is provided. (sonic-net#663) [lguohan] * 34e157e 2018-10-31 | [VS]: fix swss warm restart test (sonic-net#662) [Jipan Yang] sairedis: * c612c5e 2018-11-01 | Add specific comparison logic for more objects (sonic-net#360) (HEAD, origin/master, origin/HEAD) [Kamil Cudnik] * a6b709a 2018-10-31 | [syncd] re-establish notifications after warm boot (sonic-net#368) [Ying Xie] * d655d20 2018-10-29 | [syncd] partial warm recovery support (sonic-net#352) [Ying Xie] * 4d9aa18 2018-10-29 | Add missing object types to virtual switch (sonic-net#364) [Kamil Cudnik] * 1fdaf47 2018-10-29 | Add VS support for setting stats via redis DB channel (sonic-net#366) [Kamil Cudnik] Signed-off-by: Guohan Lu <gulv@microsoft.com>

swss: * 863b69c 2018-11-01 | [teamsyncd]: Fix bug when removing selectable in select function (#665) (HEAD, origin/master, origin/HEAD) [Shuotian Cheng] * 2c83b68 2018-10-31 | Warm reboot: bring up ports for whole system warm reboot (#653) [Qi Luo] * d049d65 2018-10-31 | [vstest]: get subscribed objects from appdb and asicdb (#664) [lguohan] * 057a329 2018-10-31 | [vstest]: change the redis mount point when --dvsname is provided. (#663) [lguohan] * 34e157e 2018-10-31 | [VS]: fix swss warm restart test (#662) [Jipan Yang] sairedis: * c612c5e 2018-11-01 | Add specific comparison logic for more objects (#360) (HEAD, origin/master, origin/HEAD) [Kamil Cudnik] * a6b709a 2018-10-31 | [syncd] re-establish notifications after warm boot (#368) [Ying Xie] * d655d20 2018-10-29 | [syncd] partial warm recovery support (#352) [Ying Xie] * 4d9aa18 2018-10-29 | Add missing object types to virtual switch (#364) [Kamil Cudnik] * 1fdaf47 2018-10-29 | Add VS support for setting stats via redis DB channel (#366) [Kamil Cudnik] Signed-off-by: Guohan Lu <gulv@microsoft.com>

Submodule src/sonic-swss 0e5c1ff..fcd091c: > [mirrororch]: Remove mirror session state after it is remvoed (sonic-net#1066) Submodule src/sonic-utilities a89b9d4..54946e9: > [acl_loader]: Add monitor port column in show mirror_session output (sonic-net#662) > [warm/fast reboot] some service docker might have been stopped already (sonic-net#668) Signed-off-by: Ying Xie <ying.xie@microsoft.com>

Submodule src/sonic-swss 0e5c1ff..fcd091c: > [mirrororch]: Remove mirror session state after it is remvoed (#1066) Submodule src/sonic-utilities a89b9d4..54946e9: > [acl_loader]: Add monitor port column in show mirror_session output (#662) > [warm/fast reboot] some service docker might have been stopped already (#668) Signed-off-by: Ying Xie <ying.xie@microsoft.com>

Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>

Update to pick up changes needed for VS gearbox - sonic-sairedis - meta/saiserialize.cpp - Fix typo at SAI_ATTR_VALUE_TYPE_ACL_FIELD_DATA_UINT32 (#662) - syncd/scripts/gbsyncd_start.sh - Rename physyncd_startup.sh/physyncd_startup.py to gbsyncd_startup.sh/gbsyncd_startup.py (#661) - syncd/scripts/gbsyncd_startup.py - Rename physyncd_startup.sh/physyncd_startup.py to gbsyncd_startup.sh/gbsyncd_startup.py (#661) - sonic-swss-common - common/database_config.json - Add restapi DB (#386) - common/redispipeline.h - Throw proper exceptions when talking with Redis (#384) - common/redisreply.cpp - Throw proper exceptions when talking with Redis (#384) - common/redisreply.h - Throw proper exceptions when talking with Redis (#384) - common/schema.h - Add restapi DB (#386) - common/table.cpp - Add restapi DB (#386) Signed-off-by Syd Logan syd.logan@broadcom.com

e98a7af95a9767093904d9e8fd320067163d5f87 (HEAD -> 201911, origin/201911) [syncd] Translate removed RIDs in fdb notification (#729) 3ceeae5371eee5b69064fa1af88f51e27caa2d36 [syncd] Process all cases fdb flush notification (#726) 115ba0783edf85658fd0329eb23796d758c309f5 fix compile error when compiling with g++-4.8.4 (#718) a67f94d3d91325516069ef8c0d99bdec30bafbce Fix typo at SAI_ATTR_VALUE_TYPE_ACL_FIELD_DATA_UINT32 (#662) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>

Update to pick up changes needed for VS gearbox - sonic-sairedis - meta/saiserialize.cpp - Fix typo at SAI_ATTR_VALUE_TYPE_ACL_FIELD_DATA_UINT32 (sonic-net#662) - syncd/scripts/gbsyncd_start.sh - Rename physyncd_startup.sh/physyncd_startup.py to gbsyncd_startup.sh/gbsyncd_startup.py (sonic-net#661) - syncd/scripts/gbsyncd_startup.py - Rename physyncd_startup.sh/physyncd_startup.py to gbsyncd_startup.sh/gbsyncd_startup.py (sonic-net#661) - sonic-swss-common - common/database_config.json - Add restapi DB (sonic-net#386) - common/redispipeline.h - Throw proper exceptions when talking with Redis (sonic-net#384) - common/redisreply.cpp - Throw proper exceptions when talking with Redis (sonic-net#384) - common/redisreply.h - Throw proper exceptions when talking with Redis (sonic-net#384) - common/schema.h - Add restapi DB (sonic-net#386) - common/table.cpp - Add restapi DB (sonic-net#386) Signed-off-by Syd Logan syd.logan@broadcom.com

…onic-net#662) This column helps checking the output monitor port for the mirror session. Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>

Looks like a typo. It should be 32 instead of 16. Signed-off-by: Ze Gan <ganze718@gmail.com>

platform/broadcom: Add a new supported device and platform, AS7712-32X

ab23d5e

* Switch Vendor: Edge-core * Switch SKU: AS7712-32X * ASIC Vendor: Broadcom * Swich ASIC: Tomahawk * Port Configuration: 32x100G * SONiC Image: SONiC-ONIE-Broadcom Signed-off-by: polly_hsu@accton.com

msftclas added the cla-already-signed label Jun 2, 2017

lguohan reviewed Jun 2, 2017

View reviewed changes

lguohan requested changes Jun 2, 2017

View reviewed changes

pollyhsu2git added 2 commits June 5, 2017 10:12

Update minigraph.xml

22ebc99

Update orchagent.sh

71ac980

stcheng reviewed Jun 5, 2017

View reviewed changes

pollyhsu2git commented Jun 5, 2017

View reviewed changes

pollyhsu2git and others added 5 commits June 5, 2017 11:42

Change the HwSku of LeafRouter with the Accton pre

015fb17

Update config

af17731

Change DEFAULT_USERNAME back to YourPaSsWoRd

Merge branch 'master' into platform-bcm-as7712

2ae9831

Merge branch 'master' into platform-bcm-as7712

c0c4846

pollyhsu2git commented Jun 6, 2017

View reviewed changes

stcheng suggested changes Jun 6, 2017

View reviewed changes

stcheng added the Enhancement ➕ label Jun 6, 2017

pollyhsu2git and others added 3 commits June 7, 2017 09:08

Merge branch 'master' into platform-bcm-as7712

c8cb0f5

[platform/broadcom]: Update Accton-AS7712-32X

5b140ec

* Modify `th-as7712-32x100G.config.bcm` based on config_checker; (Move not permitted: ccm_dma_enable / ccmdma_intr_enable / mem_cache_enable / dport_map_direct / dport_map_enable) Signed-off-by: polly_hsu@accton.com

[platform/broadcom]: Update Accton-AS7712-32X

aa2ee3d

* Undo the change of orchagent.sh upon reviewed Signed-off-by: polly_hsu@accton.com

pollyhsu2git commented Jun 7, 2017

View reviewed changes

pollyhsu2git and others added 3 commits June 7, 2017 14:26

Merge branch 'master' into platform-bcm-as7712

7f7f94e

[platform/broadcom]: Update Accton-AS7712-32X

38a39d9

* Update `minigraph.xml` with the front panel interface configuration Signed-off-by: polly_hsu@accton.com

Merge branch 'platform-bcm-as7712' of https://github.com/pollyhsu2git…

b5849aa

…/sonic-buildimage into platform-bcm-as7712

lguohan reviewed Jun 7, 2017

View reviewed changes

Merge branch 'master' into platform-bcm-as7712

5daec8d

[platform/broadcom]: Update Accton-AS7712-32X

9482a87

* Remove the SDK config, `th-as7712-32x100G.config.bcm` as it would be packed within saibcm deb package Signed-off-by: polly_hsu@accton.com

pollyhsu2git commented Jun 8, 2017

View reviewed changes

[platform/broadcom]: Update Accton-AS7712-32X

748c877

* Remove the installation of the SDK config, `th-as7712-32x100G.config.bcm` as it would be packed within saibcm deb package Signed-off-by: polly_hsu@accton.com

pollyhsu2git commented Jun 8, 2017

View reviewed changes

Merge branch 'master' into platform-bcm-as7712

3a0c12c

lguohan approved these changes Jun 11, 2017

View reviewed changes

Merge branch 'master' into platform-bcm-as7712

155a397

lguohan mentioned this pull request Jun 13, 2017

Add submodule platform/broadcom/sonic-platform-modules-accton #699

Closed

stcheng approved these changes Jun 15, 2017

View reviewed changes

Shuotian Cheng added 2 commits June 14, 2017 19:23

Merge branch 'master' into platform-bcm-as7712

896a74d

Merge branch 'master' into platform-bcm-as7712

86a6e32

stcheng merged commit c1c8a12 into sonic-net:master Jun 15, 2017

pollyhsu2git deleted the platform-bcm-as7712 branch June 16, 2017 03:23

lguohan mentioned this pull request Nov 1, 2018

[submodules]: update sonic-swss and sonic-sairedis #2220

Merged

yxieca mentioned this pull request Sep 26, 2019

[201811][utilities][swss] advance sub module head #3524

Merged

madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020

[VS]: fix swss warm restart test (sonic-net#662)

34e157e

Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>

slogan621 mentioned this pull request Sep 23, 2020

[sonic-swss-common][sonic-sairedis] Update submodules #5449

Merged

AidanCopeland pushed a commit to Metaswitch/sonic-buildimage that referenced this pull request Apr 14, 2022

Fix typo at SAI_ATTR_VALUE_TYPE_ACL_FIELD_DATA_UINT32 (sonic-net#662)

b6e5a14

Looks like a typo. It should be 32 instead of 16. Signed-off-by: Ze Gan <ganze718@gmail.com>

		@@ -0,0 +1,75 @@
		<DeviceMiniGraph xmlns:i="http://www.w3.org/2001/XMLSchema-instance" xmlns="Microsoft.Search.Autopilot.Evolution">

platform/broadcom: Add a new supported device and platform, AS7712-32X #662

platform/broadcom: Add a new supported device and platform, AS7712-32X #662

Conversation

pollyhsu2git commented Jun 2, 2017

msftclas commented Jun 2, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pollyhsu2git Jun 5, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pollyhsu2git Jun 6, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pollyhsu2git Jun 5, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stcheng commented Jun 5, 2017

pollyhsu2git left a comment

Choose a reason for hiding this comment

pollyhsu2git left a comment

Choose a reason for hiding this comment

stcheng commented Jun 6, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pollyhsu2git Jun 7, 2017 • edited

Choose a reason for hiding this comment

pollyhsu2git left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pollyhsu2git Jun 8, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pollyhsu2git Jun 8, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pollyhsu2git left a comment

Choose a reason for hiding this comment

pollyhsu2git left a comment

Choose a reason for hiding this comment

lguohan left a comment

Choose a reason for hiding this comment

pollyhsu2git commented Jun 15, 2017

stcheng commented Jun 15, 2017 • edited

pollyhsu2git Jun 5, 2017 •

edited

pollyhsu2git Jun 6, 2017 •

edited

pollyhsu2git Jun 5, 2017 •

edited

pollyhsu2git Jun 7, 2017 •

edited

pollyhsu2git left a comment •

edited

pollyhsu2git Jun 8, 2017 •

edited

pollyhsu2git Jun 8, 2017 •

edited

stcheng commented Jun 15, 2017 •

edited