[Accton] Fix high CPU utilization caused by chassis.get_change_event() #8901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* models: AS4630-54TE, AS9726-32D Signed-off-by: Sean Wu <sean_wu@edge-core.com>
* The original design will use 'docker' to check operating environment. But that command might get stuck occasionally when it is called in the context of 'determine-reboot-cause.service'. It is suspetced the reason why it gets stucked is related to the service status of 'containerd'. * Change to use 'which systemctl' to check operation environment. When systemctl exists, returns 0. (In Host os env) When it does not exist, returns 1. (In docker os env) Signed-off-by: Sean Wu <sean_wu@edge-core.com>
seanwu-ec
requested review from
prgeor,
sujinmkang and
vdahiya12
as code owners
sujinmkang
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #8900
models: AS4630-54TE, AS9726-32D
Why I did it
Correct get_change_event() wait and timeout mechanism to avoid high CPU utilization.
How I did it
Make sure get_change_event() behaves as documentation said, it can block the caller and handle timeout appropriately.
How to verify it
In pmon,
Use top to measure CPU usage of xcvrd. Make a comparison to confirm the improvement on CPU usage.
Code a script to keep polling get_change_event() and see if the returned data is exactly what we expect.
Which release branch to backport (provide reason below if selected)
Description for the changelog
[Accton] Fix xcvr busy issue
A picture of a cute animal (not mandatory but encouraged)