-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Get crm_interface fixture results on backend testbeds #12291
Merged
yxieca
merged 16 commits into
sonic-net:master
from
developfast:dojha/bugfix/test_crm_backend_test_fix
Apr 3, 2024
Merged
[Bugfix] Get crm_interface fixture results on backend testbeds #12291
yxieca
merged 16 commits into
sonic-net:master
from
developfast:dojha/bugfix/test_crm_backend_test_fix
Apr 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[pull] master from sonic-net:master
[pull] master from sonic-net:master
[pull] master from sonic-net:master
[pull] master from sonic-net:master
[pull] master from sonic-net:master
[pull] master from sonic-net:master
neethajohn
approved these changes
Apr 3, 2024
@yxieca can you pls help merge? |
@StormLiangMS , please help with cherry-pick |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Apr 11, 2024
Cherry-pick PR to 202311: #12411 |
8 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Apr 11, 2024
Cherry-pick PR to 202305: #12412 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Apr 11, 2024
mssonicbld
pushed a commit
that referenced
this pull request
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Due to a bug introduced by #5331, the crm interfaces were not being returned by the fixture correctly. The fix is to set a global return for the interfaces.
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Bugfix for crm test for backend testbed
How did you do it?
Back indent return values
How did you verify/test it?
Tested on backend lab device
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation