-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for one portChannel and one routed interface if two por… #5331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
judyjoseph
reviewed
Apr 26, 2022
7f2dcbc
to
5c0aa5c
Compare
mannytaheri
added a commit
to mannytaheri/sonic-mgmt
that referenced
this pull request
Jul 27, 2022
…Cahnnels or two routed interfaces don't exit on the dut (sonic-net#5331 mannytaheri:crm_interface) Added code to get the first set of available ports Used yield instead of return
/easycla |
judyjoseph
approved these changes
Oct 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wangxin
pushed a commit
that referenced
this pull request
Oct 31, 2022
lolyu
pushed a commit
to lolyu/sonic-mgmt
that referenced
this pull request
Dec 19, 2022
…Azure/sonic-mgmt into internal Fix merge conflicts. Commit history: - Modified args for some of the calls (sonic-net#6605) - Run telemetry tests on all DUT types in a multi-dut setup (sonic-net#6098) - [dualtor]: Fix loopback route removal (sonic-net#6555) - Added support for one portChannel and one routed interface if two por… (sonic-net#5331) - Use config_reload when recovering from internal interfaces that are in down state (sonic-net#6076) - Added python fixture for resetting config changes to fix nightly backend snmp test failures (sonic-net#6607) - Fix Python3 RuntimeError - dictionary changed size during iteration (sonic-net#6646) - [mx] Add docs for mx topo (sonic-net#6634) - [topo_mx] Add new topo for BMC Mgmt ToR Router (sonic-net#6636) - [mx] Enhance announce routes to support MX topo (sonic-net#6635) - Merge branch 'azure-master' into dev/yaqiangzhu/internal_merge
8 tasks
This was referenced Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
test_crm_nexthop_group will fail if either two PortChannels or two routed interfaces don't exits on the dut.
Added support to check for one portChannel and one routed interface on the dut also.
Type of change
Approach
What is the motivation for this PR?
To provide support for the testcase to run if only one routed interface and one PortChannel exit on the dut.
Currently the test case runs if either two portChannels or two routed interface exist.
How did you do it?
The testcase will check either for two PortChannels or two routed interfaces on the dut first.
If it does exist it will check for one routed interface and one portChannel on the dut.
How did you verify/test it?
Ran the the testcase on a dut with only one routed interface and one portChanned.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation