Add loganalyzer_common_ignore regexs for config reload on broadcom #13316

byu343 · 2024-06-15T00:14:02Z

Description of PR

Summary:
Fixes # (issue)

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Back port request

Approach

What is the motivation for this PR?

These errors are found for config reload on 202311 branch on broadcom platform and safe to ignore.

These are from the change sonic-net/sonic-swss#2598.
r, ".* ERR swss#orchagent: :- queryHashNativeHashFieldListEnumCapabilities: Failed to get attribute."
r, ". ERR swss#orchagent: :- queryHashNativeHashFieldListAttrCapabilities: Failed to get attribute."
r, ". ERR swss#orchagent: :- querySwitchEcmpHashAlgorithmEnumCapabilities: Failed to get attribute."
r, ". ERR swss#orchagent: :- querySwitchLagHashAlgorithmEnumCapabilities: Failed to get attribute.*"

r, ".* ERR syncd\d*#syncd.SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters. failed with error Feature unavailable.*"

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

…atform These errors are found for config reload on 202311 branch on broadcom platform and safe to ignore.

ZhaohuiS · 2024-06-19T03:38:52Z

ansible/roles/test/files/tools/loganalyzer/loganalyzer_common_ignore.txt

+r, ".* ERR swss#orchagent: :- queryHashNativeHashFieldListAttrCapabilities: Failed to get attribute.*"
+r, ".* ERR swss#orchagent: :- querySwitchEcmpHashAlgorithmEnumCapabilities: Failed to get attribute.*"
+r, ".* ERR swss#orchagent: :- querySwitchLagHashAlgorithmEnumCapabilities: Failed to get attribute.*"
+r, ".* ERR syncd\d*#syncd.*SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters.* failed with error Feature unavailable.*"


@byu343 for the 5 lines above I understand they are caused by sonic-net/SONiC#1101 added by Nvidia. What I am not sure is the 3 lines below, Could you please clarify why you want to ignore them? What is the real root cause for those 3 lines?

r, ".* ERR syncd\d*#syncd.SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters. failed with error Feature unavailable."
r, ". ERR syncd\d*#syncd.SAI_API_PORT:brcm_sai_get_port_stats. port fdr stats get failed with error Feature unavailable.*"
Above two lines are from broadcom SAI for reading FEC counters on certain ports not supporting them.

r, ".* ERR swss#portsyncd: :- readData: netlink reports an error=-33 on reading a netlink socket."
r, ". ERR systemd-udevd[\d*]:.* bcm0: Failed to get link config: No such device.*"
We only see occasional issues with them from our testing results. I should remove them from the this change

ZhaohuiS · 2024-06-21T14:15:04Z

ansible/roles/test/files/tools/loganalyzer/loganalyzer_common_ignore.txt

+r, ".* ERR swss#orchagent: :- querySwitchLagHashAlgorithmEnumCapabilities: Failed to get attribute.*"
+r, ".* ERR syncd\d*#syncd.*SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters.* failed with error Feature unavailable.*"
+r, ".* ERR syncd\d*#syncd.*SAI_API_PORT:brcm_sai_get_port_stats.* port fdr stats get failed with error Feature unavailable.*"
+


@byu343 thank you for the update, but I still didn't find "port fdr stats get failed with error Feature unavailable" in our nightly test result. Probably, not related to sonic-net/SONiC#1101 as well. Can we remove it for now and add it back if we observe it in our nightly test and confirm that it's not image issue?

Sure, I will create a separate PR for FEC counter error from broadcom SAI:
r, ".* ERR syncd\d*#syncd.SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters. failed with error Feature unavailable."
r, ". ERR syncd\d*#syncd.SAI_API_PORT:brcm_sai_get_port_stats. port fdr stats get failed with error Feature unavailable.*"

@byu343 I think we have some miscommunication here:
ERR syncd\d#syncd.SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters. failed with error Feature unavailable.* should be included this PR, since it is caused by sonic-net/SONiC#1101, same with ERR swss#orchagent: :- querySwitchLagHashAlgorithmEnumCapabilities: Failed to get attribute..
But I suggest don't include ERR syncd\d#syncd.SAI_API_PORT:brcm_sai_get_port_stats. port fdr stats get failed with error Feature unavailable.* in this PR, because I didn't find any of it in our nightly test.
Do you have other concerns or any misunderstanding here?

Hi @ZhaohuiS,
My understanding is that the error for _brcm_sai_read_fec_stat_err_counters is from reading the FEC counter and unrelated to the query hash-related capacities in sonic-net/SONiC#1101. But anyway, I could add it to this PR for the same reason of unblocking log checking.

"port fdr stats get failed with error Feature unavailable" We saw this a lot on 7260 t0-116. We could put this in another PR in case we will need it later.

ZhaohuiS

LGTM

StormLiangMS

LGTM

StormLiangMS · 2024-06-25T00:28:45Z

hi @yxieca @bingwang-ms for cherry pick to 202311 / 202405.

…onic-net#13316) What is the motivation for this PR? These errors are found for config reload on 202311 branch on broadcom platform and safe to ignore. These are from the change sonic-net/sonic-swss#2598. r, ".* ERR swss#orchagent: :- queryHashNativeHashFieldListEnumCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- queryHashNativeHashFieldListAttrCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- querySwitchEcmpHashAlgorithmEnumCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- querySwitchLagHashAlgorithmEnumCapabilities: Failed to get attribute.*" r, ".* ERR syncd\d*#syncd.SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters. failed with error Feature unavailable.*" How did you do it?

mssonicbld · 2024-06-25T01:27:24Z

Cherry-pick PR to 202311: #13442

…13316) What is the motivation for this PR? These errors are found for config reload on 202311 branch on broadcom platform and safe to ignore. These are from the change sonic-net/sonic-swss#2598. r, ".* ERR swss#orchagent: :- queryHashNativeHashFieldListEnumCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- queryHashNativeHashFieldListAttrCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- querySwitchEcmpHashAlgorithmEnumCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- querySwitchLagHashAlgorithmEnumCapabilities: Failed to get attribute.*" r, ".* ERR syncd\d*#syncd.SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters. failed with error Feature unavailable.*" How did you do it?

StormLiangMS · 2024-06-27T04:32:53Z

hi @bingwang-ms could you approve on 202405?

StormLiangMS · 2024-06-27T04:33:14Z

hi @bingwang-ms could you approve on 202405?

…onic-net#13316) What is the motivation for this PR? These errors are found for config reload on 202311 branch on broadcom platform and safe to ignore. These are from the change sonic-net/sonic-swss#2598. r, ".* ERR swss#orchagent: :- queryHashNativeHashFieldListEnumCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- queryHashNativeHashFieldListAttrCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- querySwitchEcmpHashAlgorithmEnumCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- querySwitchLagHashAlgorithmEnumCapabilities: Failed to get attribute.*" r, ".* ERR syncd\d*#syncd.SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters. failed with error Feature unavailable.*" How did you do it?

mssonicbld · 2024-07-04T02:45:34Z

Cherry-pick PR to 202405: #13558

…13316) What is the motivation for this PR? These errors are found for config reload on 202311 branch on broadcom platform and safe to ignore. These are from the change sonic-net/sonic-swss#2598. r, ".* ERR swss#orchagent: :- queryHashNativeHashFieldListEnumCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- queryHashNativeHashFieldListAttrCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- querySwitchEcmpHashAlgorithmEnumCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- querySwitchLagHashAlgorithmEnumCapabilities: Failed to get attribute.*" r, ".* ERR syncd\d*#syncd.SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters. failed with error Feature unavailable.*" How did you do it?

Add loganalyzer_common_ignore regexs for config reload on broadcom pl…

1edc9bb

…atform These errors are found for config reload on 202311 branch on broadcom platform and safe to ignore.

ZhaohuiS reviewed Jun 19, 2024

View reviewed changes

Remove regex for netlink and systemd-udev error

c60570c

ZhaohuiS reviewed Jun 21, 2024

View reviewed changes

Remove regex for for port fdr stats

d927ddf

byu343 force-pushed the fix-202311-loganalyzer branch from 1ae40cc to d927ddf Compare June 24, 2024 17:31

ZhaohuiS approved these changes Jun 25, 2024

View reviewed changes

ZhaohuiS added the Request for 202311 branch label Jun 25, 2024

StormLiangMS approved these changes Jun 25, 2024

View reviewed changes

StormLiangMS merged commit 2abfefc into sonic-net:master Jun 25, 2024
16 checks passed

StormLiangMS added the Request for 202405 branch label Jun 25, 2024

yxieca added the Approved for 202311 branch label Jun 25, 2024

mssonicbld added the Created PR to 202311 branch label Jun 25, 2024

mssonicbld mentioned this pull request Jun 25, 2024

[action] [PR:13316] Add loganalyzer_common_ignore regexs for config reload on broadcom #13442

Merged

8 tasks

mssonicbld added Included in 202311 branch and removed Created PR to 202311 branch labels Jun 25, 2024

StormLiangMS added the Approved for 202405 branch label Jul 4, 2024

mssonicbld added the Created PR to 202405 branch label Jul 4, 2024

mssonicbld mentioned this pull request Jul 4, 2024

[action] [PR:13316] Add loganalyzer_common_ignore regexs for config reload on broadcom #13558

Merged

8 tasks

mssonicbld added Included in 202405 branch and removed Created PR to 202405 branch labels Jul 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add loganalyzer_common_ignore regexs for config reload on broadcom #13316

Add loganalyzer_common_ignore regexs for config reload on broadcom #13316

byu343 commented Jun 15, 2024 •

edited

Loading

ZhaohuiS Jun 19, 2024

byu343 Jun 19, 2024

ZhaohuiS Jun 21, 2024

byu343 Jun 21, 2024

ZhaohuiS Jun 24, 2024 •

edited

Loading

byu343 Jun 24, 2024

ZhaohuiS left a comment

StormLiangMS left a comment

StormLiangMS commented Jun 25, 2024

mssonicbld commented Jun 25, 2024

StormLiangMS commented Jun 27, 2024

StormLiangMS commented Jun 27, 2024

mssonicbld commented Jul 4, 2024

Add loganalyzer_common_ignore regexs for config reload on broadcom #13316

Add loganalyzer_common_ignore regexs for config reload on broadcom #13316

Conversation

byu343 commented Jun 15, 2024 • edited Loading

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

ZhaohuiS Jun 19, 2024

Choose a reason for hiding this comment

byu343 Jun 19, 2024

Choose a reason for hiding this comment

ZhaohuiS Jun 21, 2024

Choose a reason for hiding this comment

byu343 Jun 21, 2024

Choose a reason for hiding this comment

ZhaohuiS Jun 24, 2024 • edited Loading

Choose a reason for hiding this comment

byu343 Jun 24, 2024

Choose a reason for hiding this comment

ZhaohuiS left a comment

Choose a reason for hiding this comment

StormLiangMS left a comment

Choose a reason for hiding this comment

StormLiangMS commented Jun 25, 2024

mssonicbld commented Jun 25, 2024

StormLiangMS commented Jun 27, 2024

StormLiangMS commented Jun 27, 2024

mssonicbld commented Jul 4, 2024

byu343 commented Jun 15, 2024 •

edited

Loading

ZhaohuiS Jun 24, 2024 •

edited

Loading