Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:13538] Remove xfail marker of ecmp/test_ecmp_sai_value.py #13600

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

mssonicbld
Copy link
Collaborator

Description of PR

Summary:
Fixes #11310
LAG and ECMP hash offset support has merged in 202311 sonic-net/sonic-swss#3138, remove the xfail marker of ecmp/test_ecmp_sai_value.py

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

After sonic-net/sonic-swss#3138, configure hash_offset along with hash_seed attribute is enabled on 202311 onwards on Broadcom T1 platfrom.

How did you do it?

Remove the xfail marker of ecmp/test_ecmp_sai_value.py

How did you verify/test it?

Run ecmp/test_ecmp_sai_values.py on 7260 T1 DUT and passed.
https://dev.azure.com/mssonic/internal/_build/results?buildId=586225&view=results

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

What is the motivation for this PR?
After sonic-net/sonic-swss#3138, configure hash_offset along with hash_seed attribute is enabled on 202311 onwards on Broadcom T1 platfrom.

How did you do it?
Remove the xfail marker of ecmp/test_ecmp_sai_value.py

How did you verify/test it?
Run ecmp/test_ecmp_sai_values.py on 7260 T1 DUT and passed.
https://dev.azure.com/mssonic/internal/_build/results?buildId=586225&view=results

Signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
@mssonicbld
Copy link
Collaborator Author

Original PR: #13538

@mssonicbld
Copy link
Collaborator Author

/azp run Azure.sonic-mgmt

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@Gfrom2016 Gfrom2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mssonicbld mssonicbld merged commit 57c58ce into sonic-net:202311 Jul 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants