Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary fdb flush for test_configurable_drop_counters #5821

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ZhaohuiS
Copy link
Contributor

@ZhaohuiS ZhaohuiS commented Jun 16, 2022

Signed-off-by: Zhaohui Sun zhaohuisun@microsoft.com

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012

Approach

What is the motivation for this PR?

test_configurable_drop_counters may cause orchagent crash during unshutdown interface/flush fdb/remove static fdb these operations.
Issue reported here: sonic-net/sonic-buildimage#11046

How did you do it?

The issue is fixed, but we can remove unnecessary fdb flush for test_configurable_drop_counters.
And also add sleep 3 sec after shutdown interface.

How did you verify/test it?

run test_configurable_drop_counters

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
@ZhaohuiS ZhaohuiS requested a review from a team as a code owner June 16, 2022 00:51
@ZhaohuiS ZhaohuiS marked this pull request as draft June 16, 2022 03:37
@yejianquan
Copy link
Collaborator

@ZhaohuiS
Sorry to comment on the draft PR,
I just see there's another related fix pr of swss sonic-net/sonic-swss#2332 from your issue
Should we keep the unnecessary clear to qualify the swss fix?

@ZhaohuiS
Copy link
Contributor Author

@ZhaohuiS Sorry to comment on the draft PR, I just see there's another related fix pr of swss Azure/sonic-swss#2332 from your issue Should we keep the unnecessary clear to qualify the swss fix?

@yejianquan Yes, I plan to hold this PR until we can verify 2332 [sonic-net/sonic-swss#2332] really fixes orchagent crash issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants