Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chassis] [multi-asic] skip override_config_table test for multi-asic platforms #9017

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

wenyiz2021
Copy link
Contributor

@wenyiz2021 wenyiz2021 commented Jul 19, 2023

Description of PR

test override_config_table/test_override_config_table.py creates empty/partial/full configuration and tries to overwrite config_db.json partially or totally, on duthost, for multi-asic platforms.

There is coming change from ndm that golden config db is going to change, so that host config and asic configs are put in the same file, distinguished by keys localhost and asic0 asic1 ... and there comes PR sonic-net/sonic-utilities#2825 to accommodate new ndm change.

with this new change, especially with sonic-net/sonic-utilities#2825, this override_config_table/test_override_config_table.py no longer works for multi-asic scenarios, because test is providing incorrect format of golden_config_db.json. e.g. localhost and asicx is missing in the partial config. Thus we need to skip this test.

Summary:
Fixes # (issue)
#8974

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

After:


override_config_table/test_override_config_table.py::test_load_minigraph_with_golden_config SKIPPED                                                                                          [100%]

-------------------------------------------------------------- generated xml file: /var/src/private/sonic-mgmt-int/tests/logs/tr.xml ---------------------------------------------------------------
===================================================================================== short test summary info ======================================================================================
SKIPPED [1] override_config_table/test_override_config_table.py: Skip override-config-table testing on multi-asic platforms, test provided golden config format is not compatible with multi-asics
==================================================================================== 1 skipped in 21.19 seconds ====================================================================================

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@wenyiz2021 wenyiz2021 requested review from arlakshm, wen587 and abdosi and removed request for arlakshm July 19, 2023 01:54
@wenyiz2021 wenyiz2021 requested a review from arlakshm July 19, 2023 01:55
@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...............................................................Passed
check for added large files..............................................Passed
check python ast.....................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
check conditional mark sort..............................................Failed
- hook id: check-conditional-mark-sort
- exit code: 1

The entries in tests/common/plugins/conditional_mark/tests_mark_conditions.yaml tests/common/plugins/conditional_mark/tests_mark_conditions_acl.yaml tests/common/plugins/conditional_mark/tests_mark_conditions_drop_packets.yaml tests/common/plugins/conditional_mark/tests_mark_conditions_platform_tests.yaml are not sorted in alphabetic order.

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@wenyiz2021
Copy link
Contributor Author

/easycla

@wenyiz2021
Copy link
Contributor Author

./EasyCLA

@wenyiz2021
Copy link
Contributor Author

/easycla

1 similar comment
@jarias-lfx
Copy link

/easycla

@wenyiz2021 wenyiz2021 merged commit 67c28eb into sonic-net:master Jul 19, 2023
12 checks passed
@wenyiz2021 wenyiz2021 self-assigned this Jul 19, 2023
@wenyiz2021 wenyiz2021 added chassis multi-ASIC Multi ASIC platform labels Jul 19, 2023
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jul 20, 2023
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202205: #9070

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants