-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chassis] [multi-asic] skip override_config_table test for multi-asic platforms #9017
Conversation
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
/easycla |
./EasyCLA |
/easycla |
1 similar comment
/easycla |
Cherry-pick PR to 202205: #9070 |
Description of PR
test
override_config_table/test_override_config_table.py
creates empty/partial/full configuration and tries to overwrite config_db.json partially or totally, on duthost, for multi-asic platforms.There is coming change from ndm that golden config db is going to change, so that host config and asic configs are put in the same file, distinguished by keys
localhost
andasic0
asic1
... and there comes PR sonic-net/sonic-utilities#2825 to accommodate new ndm change.with this new change, especially with sonic-net/sonic-utilities#2825, this
override_config_table/test_override_config_table.py
no longer works for multi-asic scenarios, because test is providing incorrect format ofgolden_config_db.json
. e.g.localhost
andasicx
is missing in the partial config. Thus we need to skip this test.Summary:
Fixes # (issue)
#8974
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
After:
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation