Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:9017] [chassis] [multi-asic] skip override_config_table test for multi-asic platforms #9070

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

mssonicbld
Copy link
Collaborator

Description of PR

test override_config_table/test_override_config_table.py creates empty/partial/full configuration and tries to overwrite config_db.json partially or totally, on duthost, for multi-asic platforms.

There is coming change from ndm that golden config db is going to change, so that host config and asic configs are put in the same file, distinguished by keys localhost and asic0 asic1 ... and there comes PR sonic-net/sonic-utilities#2825 to accommodate new ndm change.

with this new change, especially with sonic-net/sonic-utilities#2825, this override_config_table/test_override_config_table.py no longer works for multi-asic scenarios, because test is providing incorrect format of golden_config_db.json. e.g. localhost and asicx is missing in the partial config. Thus we need to skip this test.

Summary:
Fixes # (issue)
#8974

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

After:


override_config_table/test_override_config_table.py::test_load_minigraph_with_golden_config SKIPPED [100%]

-------------------------------------------------------------- generated xml file: /var/src/private/sonic-mgmt-int/tests/logs/tr.xml ---------------------------------------------------------------
===================================================================================== short test summary info ======================================================================================
SKIPPED [1] override_config_table/test_override_config_table.py: Skip override-config-table testing on multi-asic platforms, test provided golden config format is not compatible with multi-asics
==================================================================================== 1 skipped in 21.19 seconds ====================================================================================

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator Author

Original PR: #9017

@mssonicbld mssonicbld merged commit b49dd08 into sonic-net:202205 Jul 21, 2023
9 checks passed
@mssonicbld mssonicbld deleted the cherry/202205/9017 branch February 4, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants