Add depends to p4rt debian package #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libswsscommon is actually linked statically, so not technically a dependency, but it is installed anyway by the build system so there's no harm either. libswsscommon pulls in transitive libraries we do need: libhiredis, libnl*, libc, libgcc, libstdc++ libgmpxx4ldbl required for p4_symbolic
|
Thanks I was just about to push a smaller version of this :) |
rhalstea
approved these changes
Mar 8, 2022
Thanks for the quick review! I probably should have tagged you weeks ago. :) |
|
Yes, this change is required to address the libgmpxx issue. We have an outstanding PR against the sonic-buildimage master branch: sonic-net/sonic-buildimage#10566 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libswsscommon is actually linked statically, so not
technically a dependency, but it is installed anyway
by the build system so there's no harm either.
libswsscommon pulls in transitive libraries we do need:
libhiredis, libnl*, libc, libgcc, libstdc++
libgmpxx4ldbl required for p4_symbolic
(reopens #3 which was accidentally closed by a push)