Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PINS] update sonic-p4rt docker to bullseye #10182

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

rhalstea
Copy link
Contributor

@rhalstea rhalstea commented Mar 8, 2022

Why I did it

SONiC is migrating to bullseye. This will update the sonic-pins container to bullseye.

How I did it

The sonic-pins code isn't dependent on any architecture so it will already build successfully for bullseye. This PR updates the docker to use bullseye.

How to verify it

Today we cannot build the docker-sonic-p4rt.gz target (e.g. Issue #9885). With this change the docker will build successfully. The P4RT executable will not run, because of a missing runtime library, libgmpxx, which I'll address in a followup PR.

Which release branch to backport (provide reason below if selected)

None.

Description for the changelog

Update docker-sonic-p4rt.gz target to build with Bullseye instead of Buster.

Link to config_db schema for YANG module changes

N/A

A picture of a cute animal (not mandatory but encouraged)

@rhalstea
Copy link
Contributor Author

rhalstea commented Mar 8, 2022

@bocon13 @donNewtonAlpha For Info

@lguohan lguohan requested a review from saiarcot895 March 8, 2022 17:18
@lguohan lguohan added the bullseye Debian bullseye upgrade related label Mar 8, 2022
@bocon13
Copy link
Contributor

bocon13 commented Mar 8, 2022

Thanks @rhalstea for working on this!

Here's the fix on the packaging side: sonic-net/sonic-pins#4
After that's merged, we'll need to just update the submodule.

@pettershao-ragilenetworks
Copy link
Contributor

pettershao-ragilenetworks commented Mar 9, 2022

@rhalstea @bocon13 I faced the same build error when I build libsairedis locally, how can I fix this, thanks!:

ERROR: invalid type '' for SAI_ACL_COUNTER_ATTR_TABLE_ID
ERROR: flags are not defined for SAI_ACL_COUNTER_ATTR_TABLE_ID
ERROR: FATAL ERROR === MUST FIX === : Can't use an undefined value as an ARRAY reference at parse.pl line 1676.

@rhalstea
Copy link
Contributor Author

rhalstea commented Mar 9, 2022

@pettershao-ragilenetworks I haven't looked into the siaredis issue. This fix is addressing the incompatibilities in the p4rt docker. Have you tried the suggestions in this comment: #9885 (comment)

@rhalstea
Copy link
Contributor Author

Thanks @lguohan, Is there anything else needed before we merge this?

@qiluo-msft qiluo-msft merged commit 147d631 into sonic-net:master Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bullseye Debian bullseye upgrade related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants