Added PCIe transaction check for all peripherals on the bus #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to determine if there are any unreachable devices on the PCIe bus. The gold list of PCI peripherals is a static file that varies depending on the platform. BDF information is parsed from this YAML file. Transcations are then carried out to determine the health of each peripheral.
Modified cmd to be executed to setpci (does pci transaction) Added exception handling
|
@assrinivasan can you remove the ADO link. its not accessible for public |
My apologies -- done. |
Added specific check for ASIC missing to differentiate from device mismatch Added yaml support
assrinivasan
requested review from
saiarcot895
and removed request for
sujinmkang
|
@prgeor added testing details, please take a look when convenient. Thanks. |
saiarcot895
reviewed
Mar 8, 2023
prgeor
reviewed
Mar 15, 2023
prgeor
reviewed
Mar 15, 2023
prgeor
previously approved these changes
Mar 17, 2023
prgeor
reviewed
Mar 17, 2023
|
@assrinivasan code coverage is not met |
prgeor
reviewed
Mar 20, 2023
prgeor
previously approved these changes
Mar 20, 2023
|
@assrinivasan please fix the test failure |
|
@prgeor added unit tests |
prgeor
approved these changes
Jul 12, 2023
yxieca
pushed a commit
that referenced
this pull request
Jul 13, 2023
* Added PCIe transaction check for all peripherals on the bus This is to determine if there are any unreachable devices on the PCIe bus. The gold list of PCI peripherals is a static file that varies depending on the platform. BDF information is parsed from this YAML file. Transcations are then carried out to determine the health of each peripheral. * Modified code to read pcie devices from the pre-configured YAML file Modified cmd to be executed to setpci (does pci transaction) Added exception handling * Formalized syslog error messages Added specific check for ASIC missing to differentiate from device mismatch Added yaml support * Made changes to the way setpci command is called per SA review comments * Added comments per prgeor review comments * Added relevant comments per prgeor review comments * Fixed a bug that was causing UnboundLocalError. * Added unit tests for the check_pcie_devices method
|
This is a feature. Should not be back ported into feature branches. |
assrinivasan
added a commit
to assrinivasan/sonic-platform-daemons
that referenced
this pull request
Aug 8, 2023
…onic-net#331)" This reverts commit d73808c.
prgeor
pushed a commit
that referenced
this pull request
Aug 8, 2023
* Revert "Fixes for the issues uncovered by sonic-pcied unit tests (#389)" This reverts commit 76baca3. * Revert "Added PCIe transaction check for all peripherals on the bus (#331)" This reverts commit d73808c. * Fixes for the issues uncovered by sonic-pcied unit tests (#389) * Fixes for the following issues: - Lack of getKeys() impl in mock swsscommon table class in sonic-pcied - Fixed a 'set' bug in pcied that was uncovered by new code flows * Removed mocked table instances per prgeor review comments
tshalvi
pushed a commit
to tshalvi/sonic-platform-daemons
that referenced
this pull request
Sep 11, 2023
* Revert "Fixes for the issues uncovered by sonic-pcied unit tests (sonic-net#389)" This reverts commit 76baca3. * Revert "Added PCIe transaction check for all peripherals on the bus (sonic-net#331)" This reverts commit d73808c. * Fixes for the issues uncovered by sonic-pcied unit tests (sonic-net#389) * Fixes for the following issues: - Lack of getKeys() impl in mock swsscommon table class in sonic-pcied - Fixed a 'set' bug in pcied that was uncovered by new code flows * Removed mocked table instances per prgeor review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MSFT ADO: 14671564
Added code to carry out PCI transactions with all the peripherals on the device. This is to determine if there are any unreachable devices on the PCIe bus. The gold list of PCI peripherals is a static file that varies depending on the platform. BDF information is parsed from this YAML file. Transactions are then carried out to determine the health of each peripheral.
Motivation and Context
Fixes: Generate syslog alert for missing PCIe devices
How Has This Been Tested?
Manually disabled a PCI peripheral and verified that the code changes were able to pick it up:
Additional Information (Optional)