[ycabled][active-active] no initialize Async Client, when no active-active cable type; fix names for all ycabled threads #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdahiya12
changed the title
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
prgeor
previously approved these changes
Jun 19, 2023
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
zjswhhh
previously approved these changes
Jun 28, 2023
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
vdahiya12
force-pushed
the
dev/vdahiya/correct_async
branch
from
4dc7839
to
16a78cc
Compare
zjswhhh
approved these changes
Jul 7, 2023
yxieca
pushed a commit
that referenced
this pull request
Jul 7, 2023
…ctive cable type; fix names for all ycabled threads (#373) This PR intends to not start sonic-ycabled's Asynchronous client, when there is no active-active cable type. The Problem that we encounter is ycabled expects all threads to be working/running state all the time. Since there are no active-active cable_type Async client thread exits gracefully, but by design this needs to be working if added to monitor loop thread. So this PR fixes this problem by runnig the Async Client only if configuration is active-active for atleast a cable. This PR also has all the infrastructure changes UT for all Classes having infinite loops in ycabled, thus helping in picking up cases if changes break the code. Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
@yxieca please wait before merging to this repo |
|
@StormLiangMS please cherry pick to 202305 |
StormLiangMS
pushed a commit
that referenced
this pull request
Sep 21, 2023
…ctive cable type; fix names for all ycabled threads (#373) This PR intends to not start sonic-ycabled's Asynchronous client, when there is no active-active cable type. The Problem that we encounter is ycabled expects all threads to be working/running state all the time. Since there are no active-active cable_type Async client thread exits gracefully, but by design this needs to be working if added to monitor loop thread. So this PR fixes this problem by runnig the Async Client only if configuration is active-active for atleast a cable. This PR also has all the infrastructure changes UT for all Classes having infinite loops in ycabled, thus helping in picking up cases if changes break the code. Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to not start sonic-ycabled's Asynchronous client, when there is no active-active cable type.
The Problem that we encounter is ycabled expects all threads to be working/running state all the time.
Since there are no
active-activecable_type Async client thread exits gracefully,but by design this needs to be working if added to monitor loop thread. So this PR fixes this problem by runnig the Async Client only if configuration is
active-activefor atleast a cable.This PR also has all the infrastructure changes UT for all Classes having infinite loops in ycabled, thus helping in picking up cases if changes break the code.
MSFT ADO: 24121234
Description
Motivation and Context
How Has This Been Tested?
Running on DUT and UT
Additional Information (Optional)