-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vstest/subintf] Add vs test case to validate processing sequence of APPL DB keys #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
This reverts commit 2f463af.
daall
approved these changes
Mar 10, 2021
daall
pushed a commit
that referenced
this pull request
Apr 22, 2021
…APPL DB keys (#1663) Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
4 tasks
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
…APPL DB keys (sonic-net#1663) Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Crafted a vs test case to validate the processing sequence of
VLAN_SUB_INTERFACE
keys---Key without ip prefix must be processed prior to those with ip prefix when Port object representing sub port interface has not yet been created. If not this case, user configuration other thanvrf_name
in CONFIG_DB, such asadmin_status
, will be ignored in later creating SAI sub port interface, a symptom observed and fixed in #1650.Why I did it
Fix in #1650 shall pass the vs test case added here.
How I verified it
vs test on
test_sub_port_intf_appl_db_proc_seq
fails without #1650 fix.Physical parent port
admin_status
being configuredup
admin_status
being configureddown
Lag parent port
admin_status
being configuredup
admin_status
being configureddown
Details if related
VLAN_SUB_INTERFACE
keys with ip prefix intoAPPL_DB
VLAN_SUB_INTERFACE
key without ip prefix intoAPPL_DB
admin_staus
values, i.e.,up
anddown
, to make sure ASIC_DB sub interface attributeADMIN_V4_STATE
andADMIN_V6_STATE
are set according to user configuration, rather than being agnostic to user configuration as a result of Port object being created by keys with ip prefix.