[buffermgrd] Use unix socket for redis connection #3190
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenxs
approved these changes
Jun 7, 2024
dgsudharsan
approved these changes
Jun 10, 2024
|
Hi @prsunny , could you please kindly review this? |
|
Hi @prsunny , could you please review and sign-off? |
stephenxs
pushed a commit
to stephenxs/sonic-swss
that referenced
this pull request
Jun 24, 2024
Why I did this? Most of the DB connection in buffermgrd is using unix socket. There is only one DB connection which is using TCP socket. It brings a few drawback: TCP socket is less efficiency TCP socket may fail if loopback interface is down. It could cause following error:
mssonicbld
pushed a commit
to mssonicbld/sonic-swss
that referenced
this pull request
Jun 24, 2024
Why I did this? Most of the DB connection in buffermgrd is using unix socket. There is only one DB connection which is using TCP socket. It brings a few drawback: TCP socket is less efficiency TCP socket may fail if loopback interface is down. It could cause following error:
|
Cherry-pick PR to 202311: #3202 |
mssonicbld
pushed a commit
that referenced
this pull request
Jun 24, 2024
Why I did this? Most of the DB connection in buffermgrd is using unix socket. There is only one DB connection which is using TCP socket. It brings a few drawback: TCP socket is less efficiency TCP socket may fail if loopback interface is down. It could cause following error:
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-swss
that referenced
this pull request
Aug 2, 2024
Why I did this? Most of the DB connection in buffermgrd is using unix socket. There is only one DB connection which is using TCP socket. It brings a few drawback: TCP socket is less efficiency TCP socket may fail if loopback interface is down. It could cause following error:
|
Cherry-pick PR to 202405: #3249 |
mssonicbld
pushed a commit
that referenced
this pull request
Aug 2, 2024
Why I did this? Most of the DB connection in buffermgrd is using unix socket. There is only one DB connection which is using TCP socket. It brings a few drawback: TCP socket is less efficiency TCP socket may fail if loopback interface is down. It could cause following error:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did this?
Most of the DB connection in buffermgrd is using unix socket. There is only one DB connection which is using TCP socket. It brings a few drawback:
How I did this
Change TCP socket to unix socket
How I verify this
Manual test