Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLI]: 'Default' commands prevent autocomplete from displaying subcommands #27

Closed
jleveque opened this issue Apr 5, 2017 · 2 comments · Fixed by #903
Closed

[CLI]: 'Default' commands prevent autocomplete from displaying subcommands #27

jleveque opened this issue Apr 5, 2017 · 2 comments · Fixed by #903
Labels
Enhancement

Comments

@jleveque
Copy link
Contributor

jleveque commented Apr 5, 2017 •
edited
Loading

For example, typing show interfaces and pressing Tab will not display available subcommands counters or portchannel.

When redesigning the CLI command set, we should eliminate 'default' commands.
@jleveque jleveque changed the title [CLI]: 'Default' commands prevent autocomplete from showing subcommands [CLI]: 'Default' commands prevent autocomplete from displaying subcommands Apr 5, 2017
@jleveque jleveque mentioned this issue May 12, 2017
Merged
@jleveque
Copy link
Contributor Author

jleveque commented Apr 29, 2020 •
edited
Loading

Newer versions of Click support this concept natively (see invoke_without_command), so DefaultGroup is no longer necessary.

Look into inheriting click.Group in place of DefaultGroup everywhere. Then we can completely remove dependencies on click_default_group and no longer install that package.

@jleveque
Copy link
Contributor Author

jleveque commented May 4, 2020

An example of using invoke_without_command and accepting parameters can be found here: pallets/click#430 (comment). I have not verified that it works, but we could tru to utilize this if we want. Personally, I prefer to not allow groups to be invoked without subcommands, as it makes the behavior vary between different groups and isn't intuitive to the user.

@jleveque jleveque mentioned this issue May 4, 2020
Merged
praveen-li pushed a commit to praveen-li/sonic-utilities that referenced this issue Jun 30, 2020
[acl_loader/main.py]: Use get to fetch key 'ports'. (sonic-net#27)
6c20b42 
Reason:show command must work even when Ports does not exist in ACL_TABLE.

Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
vdahiya12 pushed a commit to vdahiya12/sonic-utilities that referenced this issue Jul 23, 2021
@jleveque
Add .gitignore file (sonic-net#27)
ae041bc
mihirpat1 pushed a commit to mihirpat1/sonic-utilities that referenced this issue Sep 15, 2023
@keboliu @lguohan
[sonic_platform_base] Add sonic_sfp and sonic_eeprom to sonic_platfor…
35c0301 
…m_base (sonic-net#27)

* add sonic_sfp and sonic_eeprom to sonic_platform_base

* make original sonic_sfp and sonic_eeprom as symbol link to the new subfolder under sonic_platform_base to avoid duplicate files

* Revert "make original sonic_sfp and sonic_eeprom as symbol link to the new subfolder under sonic_platform_base to avoid duplicate files"

This reverts commit 3e741dd3416c9c26a29a0a72418ea9fe467d68b6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove dependency on click-default-group package
1 participant
@jleveque