Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[show]: Remove default commands from groups as they are confusing to users #49

Merged
merged 1 commit into from
May 15, 2017
Merged

[show]: Remove default commands from groups as they are confusing to users #49

merged 1 commit into from
May 15, 2017

Conversation

jleveque
Copy link
Contributor

@jleveque jleveque commented May 11, 2017

Default commands in a group prevent the use of autocomplete, which can prevent a user from knowing all of the available commands within that group.

See issue #27

TODO: If we agree not to use "default groups" in the future (I vote "no") we can also remove the installation and importing of "click_default_group" altogether.

@jleveque jleveque self-assigned this May 11, 2017
@jleveque jleveque requested a review from lguohan May 11, 2017 20:14
@jleveque jleveque merged commit b4a04cb into sonic-net:master May 15, 2017
@jleveque jleveque deleted the remove_default_groups branch May 15, 2017 17:17
vdahiya12 pushed a commit to vdahiya12/sonic-utilities that referenced this pull request Jul 23, 2021
mihirpat1 pushed a commit to mihirpat1/sonic-utilities that referenced this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants