[load_minigraph] Delay pfcwd start until the buffer templates are rendered #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neetha John <nejo@microsoft.com>
lolyu
approved these changes
Nov 24, 2021
qiluo-msft
pushed a commit
that referenced
this pull request
Nov 30, 2021
…dered (#1937) Signed-off-by: Neetha John <nejo@microsoft.com> Fixes sonic-net/sonic-buildimage#9292 What I did Pfcwd was not getting started after executing load_minigraph after the changes done in #1508. This was because the PORT_QOS_MAP table is not yet present in config db (this gets populated only after the buffer templates are rendered) at the time we try to start pfcwd and hence the 'pfc_enable' field will always be empty and we skip writing PFC_WD table entries to config db. How I did it Delay pfcwd start until the buffer templates are rendered How to verify it Issue "config load_minigraph" with the changes and ensure that pfcwd is started on all active ports
qiluo-msft
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Dec 6, 2021
Contains the following commits 239cb5c [flex counter] Flex counter threads consume too much CPU resources (sonic-net/sonic-utilities#1925) 8a3b41a [load_minigraph] Delay pfcwd start until the buffer templates are rendered (sonic-net/sonic-utilities#1937)
5 tasks
Closed
5 tasks
abdosi
pushed a commit
that referenced
this pull request
Dec 8, 2021
…dered (#1937) Signed-off-by: Neetha John <nejo@microsoft.com> Fixes sonic-net/sonic-buildimage#9292 What I did Pfcwd was not getting started after executing load_minigraph after the changes done in #1508. This was because the PORT_QOS_MAP table is not yet present in config db (this gets populated only after the buffer templates are rendered) at the time we try to start pfcwd and hence the 'pfc_enable' field will always be empty and we skip writing PFC_WD table entries to config db. How I did it Delay pfcwd start until the buffer templates are rendered How to verify it Issue "config load_minigraph" with the changes and ensure that pfcwd is started on all active ports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Neetha John nejo@microsoft.com
Fixes sonic-net/sonic-buildimage#9292
What I did
Pfcwd was not getting started after executing load_minigraph after the changes done in #1508. This was because the PORT_QOS_MAP table is not yet present in config db (this gets populated only after the buffer templates are rendered) at the time we try to start pfcwd and hence the 'pfc_enable' field will always be empty and we skip writing PFC_WD table entries to config db.
How I did it
Delay pfcwd start until the buffer templates are rendered
How to verify it
Issue "config load_minigraph" with the changes and ensure that pfcwd is started on all active ports