Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test to check if pfcwd gets started after load_minigraph #4740

Closed
neethajohn opened this issue Nov 19, 2021 · 0 comments · Fixed by #4901
Closed

Add a test to check if pfcwd gets started after load_minigraph #4740

neethajohn opened this issue Nov 19, 2021 · 0 comments · Fixed by #4901
Assignees
@ZhaohuiS
Labels
Test gap

Comments

@neethajohn
Copy link
Contributor

Description

Details in sonic-net/sonic-utilities#1937

Steps to reproduce the issue:

  1. Issue a "config load_minigraph" and check if pfcwd is running using the "pfcwd show config" command. Pfcwd should be started on all active ports
@ZhaohuiS ZhaohuiS self-assigned this Dec 21, 2021
@ZhaohuiS ZhaohuiS mentioned this issue Jan 7, 2022
Merged
4 tasks
ZhaohuiS added a commit that referenced this issue Jan 11, 2022
@ZhaohuiS
Add a test to check if pfcwd gets started after load_minigraph (#4901)
90010b1 
What is the motivation for this PR?
To fix #4740.
Add a test to check if pfcwd gets started after load_minigraph.

How did you do it?
Add a new test case test_default_cfg_after_load_mg, steps are:
1. Add a fixture to enable pfcwd configuration in init_cfg.json file.
2. Config reload minigraph
3. Check if pfcwd gets started with command: pfcwd show config

How did you verify/test it?
Run test case test_default_cfg_after_load_mg in tests/pfcwd/test_pfc_config.py.

Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
isabelmsft pushed a commit to isabelmsft/sonic-mgmt that referenced this issue Feb 10, 2022
@ZhaohuiS @isabelmsft
Add a test to check if pfcwd gets started after load_minigraph (sonic…
89aab50 
…-net#4901)

What is the motivation for this PR?
To fix sonic-net#4740.
Add a test to check if pfcwd gets started after load_minigraph.

How did you do it?
Add a new test case test_default_cfg_after_load_mg, steps are:
1. Add a fixture to enable pfcwd configuration in init_cfg.json file.
2. Config reload minigraph
3. Check if pfcwd gets started with command: pfcwd show config

How did you verify/test it?
Run test case test_default_cfg_after_load_mg in tests/pfcwd/test_pfc_config.py.

Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZhaohuiS ZhaohuiS

Labels
Test gap
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a test to check if pfcwd gets started after load_minigraph ZhaohuiS/sonic-mgmt
2 participants
@neethajohn @ZhaohuiS