[sonic-package-manager] Drop 'expires_in' #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'expires_in' attribute for tokens is defined as optional and some Docker repositories (notably ghcr.io) do not set it. Since 'expires_in' is not used anywhere in the code, we simply drop it. Signed-off-by: Christian Svensson <blue@cmd.nu>
|
@stepanblyschak Thanks for approving, do you know who can merge the change? |
|
@bluecmd Need @qiluo-msft @renukamanavalan approval for the merge. |
|
@qiluo-msft @renukamanavalan Do you have time to review this? |
qiluo-msft
approved these changes
Aug 26, 2022
|
/easycla |
7 tasks
preetham-singh
pushed a commit
to preetham-singh/sonic-utilities
that referenced
this pull request
Nov 21, 2022
#### What I did The 'expires_in' attribute for tokens is defined as optional and some Docker repositories (notably ghcr.io) do not set it. #### How I did it Since 'expires_in' is not used anywhere in the code, we simply drop it. #### How to verify it Try to install a SONiC package from `ghcr.io`. E.g.: ``` sudo sonic-package-manager install --from-repository ghcr.io/kamelnetworks/sonic_exporter:main ``` #### Previous command output (if the output of a command-line utility has changed) ``` ghcr.io/kamelnetworks/sonic_exporter:main is going to be installed, continue? [y/N]: y Failed to install ghcr.io/kamelnetworks/sonic_exporter:main: 'expires_in' ``` #### New command output (if the output of a command-line utility has changed) Output as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
The 'expires_in' attribute for tokens is defined as optional and some
Docker repositories (notably ghcr.io) do not set it.
How I did it
Since 'expires_in' is not used anywhere in the code, we simply drop it.
How to verify it
Try to install a SONiC package from
ghcr.io. E.g.:Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
Output as expected