add lacp_rate to portchannel #2036

globaltrouble · 2022-01-25T14:08:14Z

What I did

Make lacp_rate configurable for portchannel.

	Option specifying the rate in which we'll ask our link partner
	to transmit LACPDU packets in 802.3ad mode.  Possible values
	are:

	slow
		Request partner to transmit LACPDUs every 30 seconds

	fast
		Request partner to transmit LACPDUs every 1 second

	The default is slow.

Why I did it

In case of slow lacp_rate configuration link down will be detected in 60-90 seconds, it may be to long (for example for MCLAG high availability), in case of using --fast-rate=true link down will be detected in 2-3 seconds.

How I did it

add optional argument to config portchannel command, default=slow for backward compatibility. (this PR)
parse argument in teammgr and forward it to teamd (other PR: [swss/cfgmgr] teammgr configure lacp rate sonic-swss#2121)
update docs Feature/add lacp rate SONiC#937

How to verify it

Confgiure bond on other side, then configure portchannel and sniff the traffic from it.

config portchannel add PortChannel0001 --fast-rate=true
config portchannel member add PortChannel0001 Ethernet0
config interface ip add PortChannel0001  192.168.1.2/24
tcpdump -ne

globaltrouble · 2022-01-31T10:09:11Z

@stcheng could you please review it?

msosyak · 2022-02-16T18:38:58Z

Related PR's:

msosyak · 2022-03-21T08:31:50Z

@qiluo-msft @bingwang-ms Help to merge this and related PRs, Please.

nazariig · 2022-04-05T11:26:58Z

config/main.py

 @click.pass_context
-def add_portchannel(ctx, portchannel_name, min_links, fallback):
+def add_portchannel(ctx, portchannel_name, min_links, fallback, fast_rate):


@globaltrouble please add a UTs to cover this case

bratashX · 2022-05-13T21:22:35Z

will be good to include these changes into 202111 branch

qiluo-msft · 2022-05-15T20:03:58Z

Please solve the conflicts

msosyak · 2022-07-13T08:33:14Z

Sorry for the late reaction.

@qiluo-msft Conflicts resolved.
@nazariig UT added.

nazariig · 2022-07-13T11:22:21Z

tests/portchannel_test.py

+        obj = {'db':db.cfgdb}
+
+        # add a portchannel with fats rate
+        result = runner.invoke(config.config.commands["portchannel"].commands["add"], ["PortChannel0005", "--fast-rate", "True"], obj=obj)


@globaltrouble please remove all created objects on teardown. Also suggest to have parametrization for True/False values

@nazariig Parametrization added. Regarding "remove all created objects on teardown" why it is needed? The DB is instantiated for each test from the template https://github.com/Azure/sonic-utilities/blob/3600639c16079f17089efd655c818022987032bb/tests/mock_tables/config_db.json

Regarding "remove all created objects on teardown" why it is needed?

@msosyak just a common practise, can be omitted if you make sure auto cleanup is taking place

nazariig · 2022-07-14T11:58:24Z

config/main.py

@@ -1946,8 +1946,11 @@ def portchannel(db, ctx, namespace):
 @click.argument('portchannel_name', metavar='<portchannel_name>', required=True)
 @click.option('--min-links', default=1, type=click.IntRange(1,1024))
 @click.option('--fallback', default='false')
+@click.option('--fast-rate', default='false',
+              type=click.Choice(['true', 'false'],


@globaltrouble IMHO, better to use flags or click.BOOL

In the current implementation, the syntax is the same for fallback and for fast-rate. Booth requires an argument. If change type to bool or flags then I think it should be done for both options together is separate PR

msosyak · 2022-07-19T08:59:08Z

@nazariig Do you have other comments?

msosyak · 2022-07-20T14:46:25Z

@nazariig @prsunny could we merge this?

msosyak · 2022-07-27T08:51:00Z

@nazariig Could you approve, please?

qiluo-msft · 2022-07-28T18:15:30Z

doc/Command-Reference.md

@@ -6925,12 +6925,13 @@ When any port is already member of any other portchannel and if user tries to ad
 Command takes two optional arguements given below.
 1) min-links  - minimum number of links required to bring up the portchannel
 2) fallback - true/false. LACP fallback feature can be enabled / disabled.  When it is set to true, only one member port will be selected as active per portchannel during fallback mode. Refer https://github.com/Azure/SONiC/blob/master/doc/lag/LACP%20Fallback%20Feature%20for%20SONiC_v0.5.md for more details about fallback feature.
+3) fast-rate - true/false, default is flase (slow). Option specifying the rate in which we'll ask our link partner to transmit LACPDU packets in 802.3ad mode. slow - request partner to transmit LACPDUs every 30 seconds, fast - request partner to transmit LACPDUs every 1 second. In slow mode 60-90 seconds needed to detect linkdown, in fast mode only 2-3 seconds.


typo: flase

judyjoseph

LGTM. Thinking from db migration angle as this is a new field being added -- I guess is ok as the default is false.

msosyak · 2022-08-09T09:16:32Z

/easycla

msosyak · 2022-08-09T11:48:06Z

@judyjoseph Could you help to merge this?

msosyak · 2022-08-12T07:13:36Z

@qiluo-msft Please, help to merge.

#### What I did Make lacp_rate configurable for portchannel. ``` Option specifying the rate in which we'll ask our link partner to transmit LACPDU packets in 802.3ad mode. Possible values are: slow Request partner to transmit LACPDUs every 30 seconds fast Request partner to transmit LACPDUs every 1 second The default is slow. ``` #### Why I did it In case of slow lacp_rate configuration link down will be detected in 60-90 seconds, it may be to long (for example for MCLAG high availability), in case of using ` --fast-rate=true` link down will be detected in 2-3 seconds. #### How I did it * add optional argument to `config portchannel` command, default=slow for backward compatibility. (this PR) * parse argument in `teammgr` and forward it to `teamd` (other PR: sonic-net/sonic-swss#2121) * update docs sonic-net/SONiC#937 #### How to verify it Confgiure bond on other side, then configure portchannel and sniff the traffic from it. ``` config portchannel add PortChannel0001 --fast-rate=true config portchannel member add PortChannel0001 Ethernet0 config interface ip add PortChannel0001 192.168.1.2/24 tcpdump -ne ```

globaltrouble marked this pull request as draft January 25, 2022 14:08

globaltrouble mentioned this pull request Jan 25, 2022

[swss/cfgmgr] teammgr configure lacp rate sonic-net/sonic-swss#2121

Merged

globaltrouble force-pushed the feature/add-lacp-rate-to-portchannel branch 3 times, most recently from 5f6f702 to 86f00eb Compare January 27, 2022 10:12

globaltrouble mentioned this pull request Jan 28, 2022

Feature/add lacp rate sonic-net/SONiC#937

Open

globaltrouble marked this pull request as ready for review January 28, 2022 15:01

msosyak force-pushed the feature/add-lacp-rate-to-portchannel branch from 7b7a5fe to cc62984 Compare February 3, 2022 10:00

msosyak force-pushed the feature/add-lacp-rate-to-portchannel branch 2 times, most recently from cf3037d to d5eeccd Compare February 16, 2022 18:35

nazariig suggested changes Apr 5, 2022

View reviewed changes

qiluo-msft requested review from judyjoseph and bingwang-ms April 5, 2022 21:26

msosyak force-pushed the feature/add-lacp-rate-to-portchannel branch from 34549bb to 9037aa8 Compare July 4, 2022 10:28

nazariig reviewed Jul 13, 2022

View reviewed changes

msosyak force-pushed the feature/add-lacp-rate-to-portchannel branch 2 times, most recently from f266dfb to c76a2f4 Compare July 14, 2022 10:39

nazariig reviewed Jul 14, 2022

View reviewed changes

Myron Sosyak added 3 commits July 27, 2022 01:27

Add lacp-rate option to portchannel add command

1dac8f9

Add UT

e56c587

Add parametrization

a085315

msosyak force-pushed the feature/add-lacp-rate-to-portchannel branch from c76a2f4 to a085315 Compare July 27, 2022 08:48

nazariig previously approved these changes Jul 27, 2022

View reviewed changes

qiluo-msft reviewed Jul 28, 2022

View reviewed changes

judyjoseph previously approved these changes Jul 29, 2022

View reviewed changes

fix typo

6d769ea

msosyak dismissed stale reviews from judyjoseph and nazariig via 6d769ea July 29, 2022 07:35

qiluo-msft approved these changes Aug 13, 2022

View reviewed changes

qiluo-msft merged commit 37eb2b3 into sonic-net:master Aug 13, 2022

dprital mentioned this pull request Aug 30, 2022

[submodule] Advance sonic-utilities pointer sonic-net/sonic-buildimage#11897

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add lacp_rate to portchannel #2036

add lacp_rate to portchannel #2036

globaltrouble commented Jan 25, 2022 •

edited

Loading

globaltrouble commented Jan 31, 2022

msosyak commented Feb 16, 2022

msosyak commented Mar 21, 2022 •

edited

Loading

nazariig Apr 5, 2022

bratashX commented May 13, 2022

qiluo-msft commented May 15, 2022

msosyak commented Jul 13, 2022 •

edited

Loading

nazariig Jul 13, 2022

msosyak Jul 14, 2022

nazariig Jul 14, 2022

nazariig Jul 14, 2022

msosyak Jul 19, 2022

msosyak commented Jul 19, 2022

msosyak commented Jul 20, 2022

msosyak commented Jul 27, 2022

qiluo-msft Jul 28, 2022

msosyak Jul 29, 2022

judyjoseph left a comment

msosyak commented Aug 9, 2022

msosyak commented Aug 9, 2022

msosyak commented Aug 12, 2022

add lacp_rate to portchannel #2036

add lacp_rate to portchannel #2036

Conversation

globaltrouble commented Jan 25, 2022 • edited Loading

What I did

Why I did it

How I did it

How to verify it

globaltrouble commented Jan 31, 2022

msosyak commented Feb 16, 2022

msosyak commented Mar 21, 2022 • edited Loading

Choose a reason for hiding this comment

bratashX commented May 13, 2022

qiluo-msft commented May 15, 2022

msosyak commented Jul 13, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

msosyak commented Jul 19, 2022

msosyak commented Jul 20, 2022

msosyak commented Jul 27, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

judyjoseph left a comment

Choose a reason for hiding this comment

msosyak commented Aug 9, 2022

msosyak commented Aug 9, 2022

msosyak commented Aug 12, 2022

globaltrouble commented Jan 25, 2022 •

edited

Loading

msosyak commented Mar 21, 2022 •

edited

Loading

msosyak commented Jul 13, 2022 •

edited

Loading