[config]Support multi-asic Golden Config override #2738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
judyjoseph
reviewed
Mar 31, 2023
|
Otherwise looks ok. |
qiluo-msft
reviewed
Apr 11, 2023
config/main.py
Outdated
| generate_sysinfo(ns_config_input, ns) | ||
| else: | ||
| ns_config_input = config_input | ||
| generate_sysinfo(ns_config_input) |
There was a problem hiding this comment.
Do you mean the generated sysinfo should have less priority than existing one?
Though I think they should be the same.
There was a problem hiding this comment.
Will submit another PR for sysinfo generation about override.
qiluo-msft
reviewed
Apr 11, 2023
config/main.py
Outdated
| else: | ||
| mac = device_info.get_system_mac() | ||
| else: | ||
| mac = device_info.get_system_mac() |
There was a problem hiding this comment.
I notice code duplication of https://github.com/sonic-net/sonic-buildimage/blob/d74055e12ca0ac4f44342e74ea097f03720663f7/src/sonic-config-engine/sonic-cfggen#L382-L388.
Possible to reuse code? #Pending
There was a problem hiding this comment.
Could you remove code dup in next PR?
judyjoseph
previously approved these changes
Apr 13, 2023
This reverts commit d9a2ef3.
judyjoseph
approved these changes
Apr 18, 2023
qiluo-msft
approved these changes
Apr 20, 2023
StormLiangMS
pushed a commit
that referenced
this pull request
Apr 26, 2023
#### What I did Support multi-asic Golden Config Override #### How I did it Add ConfigMgmt support for ASIC validation. Modify override config cli to support multi-asic. #### How to verify it Unit test: tests/config_override_test.py::TestConfigOverrideMultiasic::test_macsec_override PASSED [ 8%] tests/config_override_test.py::TestConfigOverrideMultiasic::test_device_metadata_table_rm PASSED [ 8%]
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
May 1, 2023
Update sonic-utilities submodule pointer to include the following: * 600377f7 [DPB]Fixing typo in config breakout output ([sonic-net#2802](sonic-net/sonic-utilities#2802)) * 8ae2424a [config]Support multi-asic Golden Config override ([sonic-net#2738](sonic-net/sonic-utilities#2738)) * 79003ab2 [chassis]: remote cli commands infra for sonic chassis ([sonic-net#2701](sonic-net/sonic-utilities#2701)) * cbc55eeb [voq][chassis][generate_dump] [BCM] Dump only the relevant BCM commands for fabric cards ([sonic-net#2606](sonic-net/sonic-utilities#2606)) * 39c94b7e [GCU] Prohibit removal of PFC_WD POLL_INTERVAL field ([sonic-net#2545](sonic-net/sonic-utilities#2545)) Signed-off-by: dprital <drorp@nvidia.com>
10 tasks
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
May 1, 2023
Update sonic-utilities submodule pointer to include the following: * 88ffb167 [config]config reload should generate sysinfo if missing ([sonic-net#2778](sonic-net/sonic-utilities#2778)) * 7443b9e5 [sonic-package-manager] support extension with multiple YANG modules ([sonic-net#2752](sonic-net/sonic-utilities#2752)) * 522c3a9e [sonic-package-manager] add support for multiple CLI plugin files ([sonic-net#2753](sonic-net/sonic-utilities#2753)) * b38fcfd1 [show][muxcable] fix RC ([sonic-net#2812](sonic-net/sonic-utilities#2812)) * 7e24463f [chassis]: remote cli commands infra for sonic chassis ([sonic-net#2701](sonic-net/sonic-utilities#2701)) * bee593e4 [DPB]Fixing typo in config breakout output ([sonic-net#2802](sonic-net/sonic-utilities#2802)) * ada603c5 [config]Support multi-asic Golden Config override ([sonic-net#2738](sonic-net/sonic-utilities#2738)) * 88a7daa8 [show][barefoot] replace shell=True ([sonic-net#2699](sonic-net/sonic-utilities#2699)) * 5e99edb5 [sonic_package_manager] replace shell=True ([sonic-net#2726](sonic-net/sonic-utilities#2726)) * b547bb45 [acl-loader] Only add default deny rule when table is L3 or L3V6 ([sonic-net#2796](sonic-net/sonic-utilities#2796)) Signed-off-by: dprital <drorp@nvidia.com>
10 tasks
|
Remove Chassis tag because there is bug in this PR and block subodule. Will create an updated PR after the revert. |
liat-grozovik
pushed a commit
that referenced
this pull request
May 3, 2023
wen587
added a commit
that referenced
this pull request
May 4, 2023
wen587
added a commit
to wen587/sonic-utilities
that referenced
this pull request
May 4, 2023
#### What I did Support multi-asic Golden Config Override #### How I did it Add ConfigMgmt support for ASIC validation. Modify override config cli to support multi-asic. #### How to verify it Unit test: tests/config_override_test.py::TestConfigOverrideMultiasic::test_macsec_override PASSED [ 8%] tests/config_override_test.py::TestConfigOverrideMultiasic::test_device_metadata_table_rm PASSED [ 8%]
qiluo-msft
pushed a commit
that referenced
this pull request
May 11, 2023
ADO: 17746282 #### What I did Support multi-asic Golden Config Override with fix based on #2738 #### How I did it Add ConfigMgmt support for ASIC validation. Modify override config cli to support multi-asic. #### How to verify it Unit test: ``` tests/config_override_test.py::TestConfigOverrideMultiasic::test_macsec_override PASSED [ 8%] tests/config_override_test.py::TestConfigOverrideMultiasic::test_device_metadata_table_rm PASSED [ 8%] ```
wen587
added a commit
to wen587/sonic-utilities
that referenced
this pull request
Jun 5, 2023
…onic-net#2825) ADO: 17746282 Support multi-asic Golden Config Override with fix based on sonic-net#2738 Add ConfigMgmt support for ASIC validation. Modify override config cli to support multi-asic. Unit test: ``` tests/config_override_test.py::TestConfigOverrideMultiasic::test_macsec_override PASSED [ 8%] tests/config_override_test.py::TestConfigOverrideMultiasic::test_device_metadata_table_rm PASSED [ 8%] ```
yxieca
pushed a commit
that referenced
this pull request
Jun 6, 2023
…2825) (#2862) ADO: 17746282 Support multi-asic Golden Config Override with fix based on #2738 Add ConfigMgmt support for ASIC validation. Modify override config cli to support multi-asic. Unit test: ``` tests/config_override_test.py::TestConfigOverrideMultiasic::test_macsec_override PASSED [ 8%] tests/config_override_test.py::TestConfigOverrideMultiasic::test_device_metadata_table_rm PASSED [ 8%] ```
pdhruv-marvell
pushed a commit
to pdhruv-marvell/sonic-utilities
that referenced
this pull request
Aug 23, 2023
…#2825) ADO: 17746282 #### What I did Support multi-asic Golden Config Override with fix based on sonic-net#2738 #### How I did it Add ConfigMgmt support for ASIC validation. Modify override config cli to support multi-asic. #### How to verify it Unit test: ``` tests/config_override_test.py::TestConfigOverrideMultiasic::test_macsec_override PASSED [ 8%] tests/config_override_test.py::TestConfigOverrideMultiasic::test_device_metadata_table_rm PASSED [ 8%] ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Support multi-asic Golden Config Override
How I did it
Add ConfigMgmt support for ASIC validation. Modify override config cli to support multi-asic.
How to verify it
Unit test:
tests/config_override_test.py::TestConfigOverrideMultiasic::test_macsec_override PASSED [ 8%]
tests/config_override_test.py::TestConfigOverrideMultiasic::test_device_metadata_table_rm PASSED [ 8%]
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)