Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[202205][config]Support multi-asic Golden Config override with fix (#2825) #2862

Merged
merged 1 commit into from
Jun 6, 2023
Merged

[202205][config]Support multi-asic Golden Config override with fix (#2825) #2862

merged 1 commit into from
Jun 6, 2023

Conversation

wen587
Copy link
Contributor

@wen587 wen587 commented Jun 5, 2023 •
edited
Loading

ADO: 17746282
Cherry-pick conflict.
Backport #2825 and fix conflict.

Tested device:

admin@str-msn2700-01:~$ show ver

SONiC Software Version: SONiC.20220531.24
Distribution: Debian 11.6
Kernel: 5.10.0-18-2-amd64
Build commit: 262ec6a387
Build date: Tue Mar 28 19:56:42 UTC 2023
Built by: cloudtest@3d43ef1cc000000

Platform: x86_64-mlnx_msn2700-r0
HwSKU: Mellanox-SN2700
ASIC: mellanox
ASIC Count: 1
Serial Number: MT2020T04272
Model Number: MSN2700-CS2FO
Hardware Revision: A2
Uptime: 07:40:46 up 36 min,  3 users,  load average: 1.32, 1.31, 1.48
Date: Tue 06 Jun 2023 07:40:46

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@wen587
[202205][config]Support multi-asic Golden Config override with fix (s…
31973ee 
…onic-net#2825)

ADO: 17746282

Support multi-asic Golden Config Override with fix based on sonic-net#2738
Add ConfigMgmt support for ASIC validation. Modify override config cli to support multi-asic.
Unit test:
```
tests/config_override_test.py::TestConfigOverrideMultiasic::test_macsec_override PASSED [  8%]
tests/config_override_test.py::TestConfigOverrideMultiasic::test_device_metadata_table_rm PASSED [  8%]
```
@wen587 wen587 changed the title [202205][config]Support multi-asic Golden Config override with fix (#2738) [202205][config]Support multi-asic Golden Config override with fix (#2825) Jun 5, 2023
@wen587 wen587 requested a review from qiluo-msft June 5, 2023 03:37
@wen587 wen587 marked this pull request as ready for review June 5, 2023 03:37
@wen587 wen587 requested a review from yxieca June 6, 2023 00:58
@yxieca yxieca merged commit 75ca81e into sonic-net:202205 Jun 6, 2023
5 checks passed
@wen587 wen587 deleted the 202205_multi_ov branch June 8, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiluo-msft qiluo-msft qiluo-msft approved these changes

@judyjoseph judyjoseph judyjoseph approved these changes

@yxieca yxieca Awaiting requested review from yxieca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wen587 @qiluo-msft @judyjoseph @yxieca