-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[warm boot] move warm reboot/fast reboot knowledge to syncd service script #372
Conversation
Let's wait sonic-net/sonic-buildimage#2242 merged or abandoned #Closed |
|
@@ -109,15 +122,15 @@ docker kill teamd > /dev/null | |||
# Kill swss dockers | |||
docker kill swss | |||
|
|||
# syncd service stop is capable of handling both warm/fast/cold shutdown | |||
systemctl stop syncd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible risk with these 2 lines.
docker kill swss
will trigger swss service stop(), and will docker stop syncd
. Then it will trigger syncd service stop().
But you manually systemctl stop syncd
again. #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested with following code:
#!/bin/bash
docker kill swss
echo $?sudo systemctl stop syncd
echo $?
sonic prompt # ./test.sh
swss
0
0
Stopping a service after it has been stopped is no-op with success result. Does this address your concern? or are you thinking about something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As comment
Kill swss docker will cause service swss to fail, systemctrl will then stop swss as result. If the flag is not set, swss will also stop syncd without letting syncd to warm shutdown. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Rebased to latest master |
…single bank FW versioning (sonic-net#372) * Display Inactive FW version from EEPROM for single bank CMIS transceivers Signed-off-by: Mihir Patel <patelmi@microsoft.com> * Increased code coverage Signed-off-by: Mihir Patel <patelmi@microsoft.com> --------- Signed-off-by: Mihir Patel <patelmi@microsoft.com>
- What I did
This PR is enabled by sonic-buildimage PR 2238
In test, we found that when issue-ing "docker kill swss", it causes swss service to become FAILED. As result, systemctrl will execute swss stop script. Which will also stop syncd service if the warmboot flag is not set in warm boot case. Before sonic-buildimage PR 2238, this will cause syncd process being killed instead of shutting down properly in both warm/fast reboot cases. Most importantly switch_remove() is not called. For both warm boot and fast reboot, properly shutting down syncd process is very crucial to the operations.
- How to verify it
Please see verification steps in sonic-buildimage PR 2238