[warm boot] move warm reboot/fast reboot knowledge to syncd service script #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's wait sonic-net/sonic-buildimage#2242 merged or abandoned #Closed |
|
qiluo-msft
reviewed
Nov 14, 2018
| @@ -109,15 +122,15 @@ docker kill teamd > /dev/null | |||
| # Kill swss dockers | |||
| docker kill swss | |||
|
|
|||
| # syncd service stop is capable of handling both warm/fast/cold shutdown | |||
| systemctl stop syncd | |||
There was a problem hiding this comment.
Possible risk with these 2 lines.
docker kill swss will trigger swss service stop(), and will docker stop syncd. Then it will trigger syncd service stop().
But you manually systemctl stop syncd again. #Closed
There was a problem hiding this comment.
I tested with following code:
#!/bin/bash
docker kill swss
echo $?sudo systemctl stop syncd
echo $?
sonic prompt # ./test.sh
swss
0
0
Stopping a service after it has been stopped is no-op with success result. Does this address your concern? or are you thinking about something else?
qiluo-msft
approved these changes
Nov 15, 2018
Kill swss docker will cause service swss to fail, systemctrl will then stop swss as result. If the flag is not set, swss will also stop syncd without letting syncd to warm shutdown. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
|
Rebased to latest master |
mihirpat1
added a commit
to mihirpat1/sonic-utilities
that referenced
this pull request
Sep 15, 2023
…single bank FW versioning (sonic-net#372) * Display Inactive FW version from EEPROM for single bank CMIS transceivers Signed-off-by: Mihir Patel <patelmi@microsoft.com> * Increased code coverage Signed-off-by: Mihir Patel <patelmi@microsoft.com> --------- Signed-off-by: Mihir Patel <patelmi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
This PR is enabled by sonic-buildimage PR 2238
In test, we found that when issue-ing "docker kill swss", it causes swss service to become FAILED. As result, systemctrl will execute swss stop script. Which will also stop syncd service if the warmboot flag is not set in warm boot case. Before sonic-buildimage PR 2238, this will cause syncd process being killed instead of shutting down properly in both warm/fast reboot cases. Most importantly switch_remove() is not called. For both warm boot and fast reboot, properly shutting down syncd process is very crucial to the operations.
- How to verify it
Please see verification steps in sonic-buildimage PR 2238