fix: allow grpc logger to truncate specific methods output #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zavgorodnii
requested review from
3Hren,
antmat and
nikonov1101
as code owners
zavgorodnii
added
💩 T: bug
nikonov1101
approved these changes
Aug 30, 2018
antmat
requested changes
Aug 30, 2018
| @@ -240,40 +240,48 @@ func verifyUnaryInterceptor() grpc.UnaryServerInterceptor { | |||
| // | |||
| // Note, that to enable tracing logging you should specify this option AFTER | |||
| // trace interceptors. | |||
| func RequestLogInterceptor(log *zap.Logger) ServerOption { | |||
| func RequestLogInterceptor(log *zap.Logger, truncatedMethods []string) ServerOption { | |||
| var truncatedMethodsSet = map[string]bool{} | |||
There was a problem hiding this comment.
It is more common to use map[string]struct{} for sets (yep, go sucks)
| return func(ctx context.Context, req interface{}, info *grpc.UnaryServerInfo, handler grpc.UnaryHandler) (interface{}, error) { | ||
| executeRequestLogging(ctx, req, info.FullMethod, log) | ||
| executeRequestLogging(ctx, req, info.FullMethod, log, truncatedMethods[MethodInfo(info.FullMethod).Method]) |
There was a problem hiding this comment.
did you test it? Because go panics on missing key
There was a problem hiding this comment.
nuh-uh no it doesn't
There was a problem hiding this comment.
yep, it looks like I was not drunk
antmat
approved these changes
Aug 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short method names should be provided, i.e.,
PushTask, not/sonm.Worker/PushTask.