feat: able to stop multiple tasks #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikonov1101
requested review from
3Hren,
antmat,
zavgorodnii and
a team
as code owners
3Hren
requested changes
Sep 20, 2018
cmd/cli/commands/printers.go
Outdated
| for _, err := range errors.GetResponse() { | ||
| status := "OK" | ||
| if len(err.Error) != 0 { | ||
| status = "FAIL " + err.GetError() |
antmat
reviewed
Sep 20, 2018
cmd/cli/commands/printers.go
Outdated
| @@ -532,6 +532,20 @@ func printErrorById(cmd *cobra.Command, errors *pb.ErrorByID) { | |||
| } | |||
| } | |||
|
|
|||
| func printStringErrorsById(cmd *cobra.Command, errors *pb.ErrorByStringID) { | |||
3Hren
requested changes
Sep 20, 2018
cmd/cli/commands/printers.go
Outdated
| @@ -532,6 +532,20 @@ func printErrorById(cmd *cobra.Command, errors *pb.ErrorByID) { | |||
| } | |||
| } | |||
|
|
|||
| func printStringErrorsById(cmd *cobra.Command, errors *pb.ErrorByStringID) { | |||
There was a problem hiding this comment.
This function is some kind similar to the printErrorById. Please, find a way to decompose this.
nikonov1101
force-pushed
the
feat/node/stop-multiple-tasks
branch
2 times, most recently
from
644d062
to
54dbb6e
Compare
antmat
force-pushed
the
feat/node/stop-multiple-tasks
branch
from
54dbb6e
to
981f57b
Compare
nikonov1101
force-pushed
the
feat/node/stop-multiple-tasks
branch
from
981f57b
to
07bf526
Compare
This commit adds a new method to the Node API which provides able to stop several tasks at once.
nikonov1101
force-pushed
the
feat/node/stop-multiple-tasks
branch
from
07bf526
to
ccd38fb
Compare
antmat
approved these changes
Oct 12, 2018
3Hren
approved these changes
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new method to the Node API which provides able to stop several tasks at once.
Closes #1488 #1487