-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: able to stop multiple tasks #1504
Conversation
cmd/cli/commands/printers.go
Outdated
for _, err := range errors.GetResponse() { | ||
status := "OK" | ||
if len(err.Error) != 0 { | ||
status = "FAIL " + err.GetError() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FAIL :
cmd/cli/commands/printers.go
Outdated
@@ -532,6 +532,20 @@ func printErrorById(cmd *cobra.Command, errors *pb.ErrorByID) { | |||
} | |||
} | |||
|
|||
func printStringErrorsById(cmd *cobra.Command, errors *pb.ErrorByStringID) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
printErrorsByStringId
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason behind of doing this in Node API instead of Worker?
cmd/cli/commands/printers.go
Outdated
@@ -532,6 +532,20 @@ func printErrorById(cmd *cobra.Command, errors *pb.ErrorByID) { | |||
} | |||
} | |||
|
|||
func printStringErrorsById(cmd *cobra.Command, errors *pb.ErrorByStringID) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is some kind similar to the printErrorById
. Please, find a way to decompose this.
644d062
to
54dbb6e
Compare
54dbb6e
to
981f57b
Compare
981f57b
to
07bf526
Compare
This commit adds a new method to the Node API which provides able to stop several tasks at once.
07bf526
to
ccd38fb
Compare
This commit adds a new method to the Node API which provides able to stop several tasks at once.
Closes #1488 #1487