-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
library: Add Box entry #216
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and I especially like the UX of the slider to change the alignment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome to get an interactive Box demo 👍
src/Library/demos/Box/main.blp
Outdated
CheckButton toggle_orient { | ||
label: "Toggle Orientation"; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the the name of the property and the name of the possible values so it clears to users what we are changing here.
orientation: vertical|horizontal
I'd suggest using grouped toggle buttons (see #219)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This really great for demonstrating both GtkBox
and alignment/expansion, well done!
Just a few layout tweaks and I think this is good to go if @sonnyp agrees.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 😄 |
This PR attempts to add an interactive demo for
Gtk.Box
Issue workbenchdev/demos#3