library: Add Box entry#216
Merged
sonnyp merged 8 commits intoworkbenchdev:mainfrom Mar 13, 2023
Merged
Conversation
andyholmes
requested changes
Mar 12, 2023
Contributor
andyholmes
left a comment
andyholmes
left a comment
There was a problem hiding this comment.
This looks good and I especially like the UX of the slider to change the alignment.
sonnyp
reviewed
Mar 12, 2023
Contributor
sonnyp
left a comment
sonnyp
left a comment
There was a problem hiding this comment.
Awesome to get an interactive Box demo 👍
Comment on lines
+58
to
+60
| CheckButton toggle_orient { | ||
| label: "Toggle Orientation"; | ||
| } |
Contributor
There was a problem hiding this comment.
Please use the the name of the property and the name of the possible values so it clears to users what we are changing here.
orientation: vertical|horizontal
I'd suggest using grouped toggle buttons (see #219)
andyholmes
requested changes
Mar 13, 2023
Contributor
andyholmes
left a comment
andyholmes
left a comment
There was a problem hiding this comment.
This really great for demonstrating both GtkBox and alignment/expansion, well done!
Just a few layout tweaks and I think this is good to go if @sonnyp agrees.
Contributor
Author
|
Thanks! 😄 |
sonnyp
pushed a commit
to SoNiC-HeRE/Workbench
that referenced
this pull request
Mar 21, 2023
andyholmes
pushed a commit
to andyholmes/Workbench
that referenced
this pull request
Mar 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to add an interactive demo for
Gtk.BoxIssue workbenchdev/demos#3