Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

library: Add Color Dialog entry #232

Merged
merged 3 commits into from
Mar 21, 2023
Merged

library: Add Color Dialog entry #232

merged 3 commits into from
Mar 21, 2023

Conversation

AkshayWarrier
Copy link
Contributor

Adds Color Dialog entry.
Issue workbenchdev/demos#3

@sonnyp sonnyp requested a review from andyholmes March 16, 2023 20:02
andyholmes
andyholmes requested changes Mar 19, 2023
View reviewed changes
Copy link
Contributor

@andyholmes andyholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great demo, and good job confirming the bug in GJS while working through it.

Just a few cleanups and this will make a great demo of the high-level tools in the platform.

src/Library/demos/Color Dialog/main.blp Show resolved Hide resolved
src/Library/demos/Color Dialog/main.blp Outdated Show resolved Hide resolved
src/Library/demos/Color Dialog/main.blp Outdated Show resolved Hide resolved
src/Library/demos/Color Dialog/main.js Show resolved Hide resolved
src/Library/demos/Color Dialog/main.js Outdated Show resolved Hide resolved
src/Library/demos/Color Dialog/main.js Show resolved Hide resolved
andyholmes
andyholmes approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@andyholmes andyholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonnyp sonnyp merged commit 5260a3f into workbenchdev:main Mar 21, 2023
@AkshayWarrier AkshayWarrier deleted the add-color-dialog-entry branch March 24, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyholmes andyholmes andyholmes approved these changes

Assignees

@andyholmes andyholmes

Labels
Library 📚️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AkshayWarrier @andyholmes @sonnyp