Skip to content

library: Add Color Dialog entry#232

Merged
sonnyp merged 3 commits intoworkbenchdev:mainfrom
AkshayWarrier:add-color-dialog-entry
Mar 21, 2023
Merged

library: Add Color Dialog entry#232
sonnyp merged 3 commits intoworkbenchdev:mainfrom
AkshayWarrier:add-color-dialog-entry

Conversation

@AkshayWarrier
Copy link
Copy Markdown
Contributor

Adds Color Dialog entry.
Issue workbenchdev/demos#3

Copy link
Copy Markdown
Contributor

@andyholmes andyholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great demo, and good job confirming the bug in GJS while working through it.

Just a few cleanups and this will make a great demo of the high-level tools in the platform.

Comment thread src/Library/demos/Color Dialog/main.blp
Comment thread src/Library/demos/Color Dialog/main.blp Outdated
Comment thread src/Library/demos/Color Dialog/main.blp Outdated
Comment thread src/Library/demos/Color Dialog/main.js
Comment thread src/Library/demos/Color Dialog/main.js Outdated
Comment thread src/Library/demos/Color Dialog/main.js
Copy link
Copy Markdown
Contributor

@andyholmes andyholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonnyp sonnyp merged commit 5260a3f into workbenchdev:main Mar 21, 2023
@AkshayWarrier AkshayWarrier deleted the add-color-dialog-entry branch March 24, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants