-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
library: Add TabView entry #304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks really great, what do you think @sonnyp?
"category": "user_interface", | ||
"category": "navigation", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move this to a separate commit? I would squash the other two commits into one, but separate this change into a commit after that moves the View Switcher into the new category.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andyholmes keep in mind that the merge strategy is Squash so all commits get squashed into a single commit with the PR title as commit message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, as long as your fine with those changes being in one commit :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind
Looks fantastic. One small problem is it doesn't support dragging the tab out of the window.
I think it's fine, supporting it would make the demo convoluted |
Closes #291
Adds demo entry for
AdwTabView
. Also creates a new section "Navigation" in the library.