Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

library: Add TabView entry #304

Merged
merged 2 commits into from
Jun 7, 2023
Merged

library: Add TabView entry #304

merged 2 commits into from
Jun 7, 2023

Conversation

AkshayWarrier
Copy link
Contributor

Closes #291
Adds demo entry for AdwTabView. Also creates a new section "Navigation" in the library.

andyholmes
andyholmes approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@andyholmes andyholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks really great, what do you think @sonnyp?

src/Library/demos/View Switcher/main.json
"category": "user_interface",
"category": "navigation",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this to a separate commit? I would squash the other two commits into one, but separate this change into a commit after that moves the View Switcher into the new category.

Copy link
Contributor

@sonnyp sonnyp Jun 5, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andyholmes keep in mind that the merge strategy is Squash so all commits get squashed into a single commit with the PR title as commit message.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, as long as your fine with those changes being in one commit :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind

@andyholmes andyholmes self-assigned this Jun 5, 2023
@sonnyp
Copy link
Contributor

sonnyp commented Jun 7, 2023

Looks fantastic.

One small problem is it doesn't support dragging the tab out of the window.

Adwaita-Critical: AdwTabView::create-window handler must not return NULL

I think it's fine, supporting it would make the demo convoluted

@sonnyp sonnyp merged commit 3148d51 into main Jun 7, 2023
@sonnyp sonnyp deleted the akshaywarrier/tabview branch June 7, 2023 10:20
sonnyp pushed a commit that referenced this pull request Jun 10, 2023
@AkshayWarrier @sonnyp
library: Add TabView entry (#304)
59a8e96
sonnyp pushed a commit to SoNiC-HeRE/Workbench that referenced this pull request Aug 13, 2023
@AkshayWarrier @sonnyp
library: Add TabView entry (workbenchdev#304)
f1b55ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonnyp sonnyp sonnyp left review comments

@andyholmes andyholmes andyholmes approved these changes

Assignees

@andyholmes andyholmes

Labels
Library 📚️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AdwTabView
3 participants
@AkshayWarrier @sonnyp @andyholmes