Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library: Add AdwBanner entry #313

Merged
merged 2 commits into from
Jun 14, 2023
Merged

library: Add AdwBanner entry #313

merged 2 commits into from
Jun 14, 2023

Conversation

AkshayWarrier
Copy link
Contributor

Closes #285

Copy link
Contributor

@andyholmes andyholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few missed translatables and an unneeded container.

src/Library/demos/Banner/main.blp Outdated Show resolved Hide resolved
src/Library/demos/Banner/main.json Outdated Show resolved Hide resolved
src/Library/demos/Banner/main.blp Outdated Show resolved Hide resolved
src/Library/demos/Banner/main.blp Show resolved Hide resolved
@andyholmes andyholmes merged commit f7884f9 into main Jun 14, 2023
@sonnyp sonnyp deleted the akshaywarrier/banner branch June 15, 2023 19:48
@sonnyp sonnyp mentioned this pull request Jun 15, 2023
sonnyp pushed a commit that referenced this pull request Jun 17, 2023
* library: Add AdwBanner entry
* Banner: Translate strings
sonnyp pushed a commit that referenced this pull request Jun 17, 2023
* library: Add AdwBanner entry
* Banner: Translate strings
sonnyp pushed a commit that referenced this pull request Jun 17, 2023
* library: Add AdwBanner entry
* Banner: Translate strings
sonnyp pushed a commit that referenced this pull request Jun 20, 2023
* library: Add AdwBanner entry
* Banner: Translate strings
sonnyp pushed a commit to SoNiC-HeRE/Workbench that referenced this pull request Aug 13, 2023
* library: Add AdwBanner entry
* Banner: Translate strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adw banner
3 participants