Library: Add Banner Entry #243
Conversation
src/Library/demos/Banner/main.js
Outdated
|
|
||
| function adwBanner() { | ||
| // Create a new AdwBanner widget | ||
| const banner = new Adw.Banner({ |
There was a problem hiding this comment.
Similar to #248
please create the banner from the blueprint
There was a problem hiding this comment.
Since these are generally intended to be place in a window, directly under the header bar, it would be a good idea to create a small window to demonstrate this, too.
The button in Workbench could pop up a window, and contain a few widget to control the info bar's properties.
There was a problem hiding this comment.
Agree with Andy, the Banner should be in a Window.
No need for a custom button to open the window though - Workbench will directly offer the option if it detects a Window in the Blueprint. Similar to the "Window" library entry.
There was a problem hiding this comment.
Actually, the libadwaita demo doesn't use an external banner for its demo – I think it's safe to follow them and makes the demo visible immediately.
works for you @andyholmes ?
There was a problem hiding this comment.
Yes, that's good too. I think the important part is that it doesn't have margins on the top or left/right sides.
Replicating the libadwaita demo is good idea in general I think.
andyholmes
left a comment
andyholmes
left a comment
There was a problem hiding this comment.
Looking better!
Be sure to mark all user-visible strings in the .js and .blp file as translatable, by putting them in the gettext function, like _("Words to translate").
| Adw.Banner banner{ | ||
| button-label: "Troubleshoot"; | ||
| title: "An error occurred: Could not resolve host."; | ||
| revealed: true; | ||
| use-markup: true; | ||
| margin-bottom: 20; | ||
| } |
There was a problem hiding this comment.
This is better, but the banner should really be up at the top of the window, with no margins, right under the header bar.
Then maybe make it so clicking "Troubleshoot" hides the banner and shows the toast. Where the banner is now, add a button so the banner can be re-opened.
| Adw.ToastOverlay overlay { | ||
| Adw.StatusPage { | ||
| title: "Adw Banner"; | ||
| description: "Gnome Banner Test"; |
There was a problem hiding this comment.
| description: "Gnome Banner Test"; | |
| description: "GNOME Banner Test"; |
sonnyp
force-pushed
the
main
branch
3 times, most recently
from
05f69f1 to
55e450f
Compare
|
hey @Kodecheff, do you want to finish this? If so, make sure to add your name to the list of contributors in about.js |
3 participants
Fixes #285