Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check comments #78

Merged
merged 12 commits into from
Sep 11, 2023
Merged

Check comments #78

merged 12 commits into from
Sep 11, 2023

Conversation

sonomirco
Copy link
Owner

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🔖 Release
  • 🚩 Other

Description

This PR [adds/removes/fixes/replaces] this [feature/bug/etc].

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 readme
  • 📜 contributing.md
  • 📓 docs
  • 📕 storybook
  • 🙅 no documentation needed

github-actions[bot]
github-actions bot requested changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request has not labels. Please provide at list one labels identifing this pull request.

@sonomirco
Copy link
Owner Author

sonomirco commented Sep 11, 2023 •
edited
Loading

Please complete the following checklist:

Thank you, MircoB for taking the time to review our project. In order to complete the review process, we kindly request your signoff by filling out this checklist. Thanks again! 🙏

If you did a Code review

  • I've reviewed the code
  • I don't see bugs in the code
  • The code is justifiably easy to read and understand
  • The code meets any acceptance criteria agreed to for the work
  • The code doesn't implement additional and unnecessary functionality
  • There are no linter errors
  • The code follows team unit testing standards if developed
  • The code style and structure follows the project standards

If you did a Node review

  • I've downloaded the node and tested
  • I don't see bugs in the functionality of the nodes
  • The nodes have all the inputs and outputs required
  • The nodes are well documented

Document review

  • The documentation clearly describe the implementation

github-actions[bot]
github-actions bot requested changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request has not labels. Please provide at list one labels identifing this pull request.

github-actions[bot]
github-actions bot requested changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request has not labels. Please provide at list one labels identifing this pull request.

github-actions[bot]
github-actions bot requested changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request has not labels. Please provide at list one labels identifing this pull request.

github-actions[bot]
github-actions bot requested changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request has not labels. Please provide at list one labels identifing this pull request.

github-actions[bot]
github-actions bot requested changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request has not labels. Please provide at list one labels identifing this pull request.

github-actions[bot]
github-actions bot requested changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request has not labels. Please provide at list one labels identifing this pull request.

github-actions[bot]
github-actions bot requested changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request has not labels. Please provide at list one labels identifing this pull request.

github-actions[bot]
github-actions bot requested changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request has not labels. Please provide at list one labels identifing this pull request.

github-actions[bot]
github-actions bot requested changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request has not labels. Please provide at list one labels identifing this pull request.

github-actions[bot]
github-actions bot requested changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request has not labels. Please provide at list one labels identifing this pull request.

@sonomirco sonomirco added the bug Something isn't working label Sep 11, 2023
@sonomirco sonomirco merged commit 64ca1b7 into develop Sep 11, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions requested changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sonomirco