Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONOTMERGE/PLEASEDISCUSS] sensors: Remove /data dependencies for earlier start #706

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

MarijnS95
Copy link
Contributor

@MarijnS95 MarijnS95 commented Mar 18, 2020

Fixes sonyxperiadev/bug_tracker#515

Sensors do not seem to depend on data files at all, only persist is
(supposed to be) used. Aside from that starting the service this late
(after the FDE decryption password has been entered) seems too late to
get sensors working properly.

This patch enables the service as soon as the dsp is up (devup=1) and
moves the service to the core class to be started early and never
restarted when /data is mounted. Furthermore enabling the service rather
than explicitly starting it allows the service to be restarted in the
event of a crash.

Aside from that folder creation is removed, which does not seem to be
necessary.

Sensors do not seem to depend on data files at all, only persist is
(supposed to be) used. Aside from that starting the service this late
(after the FDE decryption password has been entered) seems too late to
get sensors working properly.

This patch enables the service as soon as the dsp is up (devup=1) and
moves the service to the core class to be started early and never
restarted when /data is mounted. Furthermore enabling the service rather
than explicitly starting it allows the service to be restarted in the
event of a crash.

Aside from that folder creation is removed, which does not seem to be
necessary.

Signed-off-by: Marijn Suijten <marijns95@gmail.com>
@jerpelea jerpelea merged commit f7d6de9 into sonyxperiadev:o-mr1 Mar 19, 2020
@MarijnS95 MarijnS95 deleted the o-mr1 branch March 26, 2020 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants