[Q] hardware/adreno: Convert vendor->odm symlink to ro.hardware property #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android is continuously clamping down on symlink hacks (see the report in [1]) and for a good reason: they provide a perfectly valid alternative using `ro.hardware.<module name>` to change the platform name of a module that needs to be searched for. On all our platforms the Vulkan library is called `vulkan.qcom.so` instead of `vulkan.$(TARGET_BOARD_PLATFORM).so` and Android can simply be taught to search for the former instead of the latter by setting `ro.hardware.vulkan=qcom`. [1]: sonyxperiadev/bug_tracker#718 Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
|
Vulkan is still broken without the symlink. Just tested on Nile. |
|
@bartcubbins any information at all that might help understand what is going on? Logs? |
|
|
|
@bartcubbins Correct, it loads from an SPHAL, and griffin:/odm/lib64 # ls -l /odm/lib64/vulkan.qcom.so
lrwxrwxrwx 1 root root 17 2021-09-28 21:20 /odm/lib64/vulkan.qcom.so -> hw/vulkan.qcom.soNo matter how dirty, works. |
|
Restoring part of the old behaviour in #865, validated on Griffin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes sonyxperiadev/bug_tracker#718
Previously submitted in #565 and #642
Android is continuously clamping down on symlink hacks (see the report in 1) and for a good reason: they provide a perfectly valid alternative using
ro.hardware.<module name>to change the platform name of a module that needs to be searched for. On all our platforms the Vulkan library is calledvulkan.qcom.soinstead ofvulkan.$(TARGET_BOARD_PLATFORM).soand Android can simply be taught to search for the former instead of the latter by settingro.hardware.vulkan=qcom.Signed-off-by: Marijn Suijten marijn.suijten@somainline.org