Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AsmMethodSource assignReadOps(...) always false #472

Merged
merged 3 commits into from
May 19, 2022
Merged

Fix AsmMethodSource assignReadOps(...) always false #472

merged 3 commits into from
May 19, 2022

Conversation

stschott
Copy link
Collaborator

Fixed an if condition in the AsmMethodSource class that always evaluated to false and created redundant jimple statements.

Also updated the test cases to account for the removal of the redundant jimple statements.

See old Soot PR #1834

swissiety
swissiety approved these changes May 19, 2022
View reviewed changes
Copy link
Collaborator

@swissiety swissiety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that it removes the array index indirection is nice as well - thanks!

@swissiety swissiety merged commit 32c48e6 into develop May 19, 2022
@swissiety swissiety deleted the fix/AsmMethodSource-always-false branch May 19, 2022 13:47
Momo-Not-Emo
Momo-Not-Emo reviewed Feb 4, 2024
View reviewed changes
Copy link
Contributor

@Momo-Not-Emo Momo-Not-Emo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue of redundant statements does not seem to be fully resolved. Some redundant statements persist, but they do not appear when using the latest version of Soot.

.../src/test/java/de/upb/swt/soot/test/java/bytecode/minimaltestsuite/java6/AutoboxingTest.java Show resolved Hide resolved
...rc/test/java/de/upb/swt/soot/test/java/bytecode/minimaltestsuite/java6/GenTypeParamTest.java Show resolved Hide resolved
.../src/test/java/de/upb/swt/soot/test/java/bytecode/minimaltestsuite/java6/ReflectionTest.java Show resolved Hide resolved
...c/test/java/de/upb/swt/soot/test/java/bytecode/minimaltestsuite/java6/UncheckedCastTest.java Show resolved Hide resolved
@swissiety
Copy link
Collaborator

swissiety commented Feb 4, 2024 •
edited
Loading

@Momo-Not-Emo to achieve the described effect you need to enable the BodyInterceptor Aggregator - as the BodyInterceptors are currently still under revision they are not enabled by default, yet.

In Soot the Aggregator BodyTransformer is enabled by default - if you disable it, the generated Jimple by Soot should look somehow similar to SootUp - i.e. this PR addressed a different problem.

This was referenced Feb 7, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Momo-Not-Emo Momo-Not-Emo Momo-Not-Emo left review comments

@swissiety swissiety swissiety approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stschott @swissiety @Momo-Not-Emo