Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit uses of verify_ssl #1704

Closed
half-duplex opened this issue Oct 9, 2019 · 2 comments · Fixed by #1706
Closed

Audit uses of verify_ssl #1704

half-duplex opened this issue Oct 9, 2019 · 2 comments · Fixed by #1706
Assignees
Labels
Milestone

Comments

@half-duplex
Copy link
Member

verify_ssl should only be used for the IRC server connection. If anyone needs to verify_ssl=False to talk to youtube, xkcd, etc. in 2019, they've got bigger problems they should fix first.

@half-duplex half-duplex self-assigned this Oct 9, 2019
@dgw
Copy link
Member

dgw commented Oct 9, 2019

If anyone needs to verify_ssl=False to talk to youtube, xkcd, etc. in 2019, they've got bigger problems they should fix first.

🙌🙌🙌🙌

There's a fair bit of nonsense to handle the case of SSL not being available, probably from the days of py2.4/2.5 or some other really old version from before even Willie (let alone Sopel) existed. We can probably ditch all of it at this point. I don't think it's even possible to install Python without SSL on any system you'd want to connect to the Internet now.

@dgw dgw added this to the 7.0.0 milestone Oct 9, 2019
@dgw dgw added the Tracking label Oct 9, 2019
@Exirel
Copy link
Contributor

Exirel commented Oct 9, 2019

You can still do that (install without correct SSL support) thanks to Python 2.7. From my experience, at least on Ubuntu 18.04 you still have problems with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants