plugins: remove nonsense uses of core.verify_ssl #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exirel
approved these changes
Oct 9, 2019
dgw
approved these changes
Oct 10, 2019
There was a problem hiding this comment.
I'm going to keep thinking about verification for find_title(). Having it enabled there is of questionable importance (it's just fetching a page title), and leads to bad UX if someone uses .title on an invalid HTTPS link: the bot appears to ignore the command. (That's not a change to the behavior when verify=True; it's just that verify now will always be True.)
So I'll shift focus from verify_ssl to the UX of title-fetching sites with bad certs. 😸
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1704, more info there.