bot: new setup sequence #1597
Merged
bot: new setup sequence #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❤️ |
dgw
requested changes
Jul 5, 2019
|
What's wrong with you, Scrutinizer? |
|
Scrutinizer is just a flake. |
|
I had to rebase because of a conflict. :( |
Sopel's setup sequence is now: * setup logging * setup plugins * start Job Scheduler There are two major change: * Job Scheduler is now started after setup is complete * Logging setup is now called from `Sopel.setup` There is no good reason for the Job Scheduler to be started before the bot is ready to run, since jobs can be safely added or removed while it's not running. One may even consider that we should start the Job Sceduler once the bot is connected only - but that's for another day.
Again. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first, I had to rework the Job Scheduler in order to test how Sopel registers and unregisters plugins, which was annoying. But then, the solution wasn't perfect: I didn't like to have to manually stop the scheduler for testing purpose—which is time consuming and a bad thing when your test suite grow a bit (a lot at the moment). Aside from that, it also means that plugins where loaded, even if I didn't want them to be, or even needed to be. This is the first thing I fixed, by moving the call to
Sopel.setup()outside ofSopel.__init__().Then, I realized: wait a minute... why do we setup plugins inside Sopel, but not logging? I couldn't find a good reason, so I moved that into Sopel's setup sequence.
Eventually, I thought: why do I even bother with the scheduler? Why do we need it started before anything else is even loaded? Answer is: we don't. We don't need that, and we don't have to start it whenever we instantiate
Sopel.So here we go:
all wrapped nicely into the old but still relevant
Sopel.setup()method.BONUS POINT: now the tests are slightly faster, and it's one step closer to facilitate reusability of
sopel.bot.Sopelclass for testing purpose (and everything else).