Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isup: minor cleanup with tests #1609

Merged
merged 4 commits into from
Jul 19, 2019
Merged

isup: minor cleanup with tests #1609

merged 4 commits into from
Jul 19, 2019

Conversation

Exirel
Copy link
Contributor

@Exirel Exirel commented May 16, 2019

Just A Small PR.©

I didn't want to change how the "is this an URL?" checks are performed, but at least they are tested now.

@Exirel Exirel added this to the 7.0.0 milestone May 16, 2019
@Exirel Exirel requested a review from dgw May 16, 2019 22:14
dgw
dgw requested changes Jul 5, 2019
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously caught typo was the only thing worth noting. 😹

test/modules/test_modules_isup.py Outdated Show resolved Hide resolved
@Exirel
Copy link
Contributor Author

Exirel commented Jul 5, 2019

@dgw should be OK now

dgw
dgw approved these changes Jul 5, 2019
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yerp. Let's go! :shipit:

@dgw dgw merged commit 51bab0b into sopel-irc:master Jul 19, 2019
@Exirel Exirel deleted the quality-isup branch September 5, 2019 09:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgw dgw dgw approved these changes

Assignees

@Exirel Exirel

Labels
Low Priority Tweak
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Exirel @dgw