dice, choose: extract .choose command into own module
#1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could have moved it to `rand.py`, but it doesn't *really* fit in any better there. There's very little cost to having a standalone file for this command aside from possibly breaking exclude settings in existing Sopel installations (and we're already adding other new modules in 7.0). Made sure this new file credits all the right people. Namely, I added Exirel to the header, because he did a significant chunk of work on this function last year.
Exirel
approved these changes
Aug 12, 2019
|
Oh yeah I remember that one. It's a good idea! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could have moved it to
rand.py, but it doesn't really fit in any better there. There's very little cost to having a standalone file for this command aside from possibly breaking exclude settings in existing Sopel installations (and we're already adding other new modules in 7.0).Made sure this new file credits all the right people. Namely, I added Exirel to the header, because he did a significant chunk of work on this function last year.