Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: more about nick, user, and name #1680

Merged
merged 3 commits into from
Nov 6, 2019

Conversation

Exirel
Copy link
Contributor

@Exirel Exirel commented Aug 13, 2019

After we got a question about that on IRC, I thought it could be a good idea to improve the documentation for nick, user, and name.

Note: I'd like to have #1668 merged so the doc stop complaining about that stupid mistake I made.

Also: .. highlight:: ini can be used to remove the usage of .. code-block:: ini in the whole file, since we don't show Python code in that particular file, but a lot of ini-like code sample.

@Exirel Exirel added this to the 7.0.0 milestone Aug 13, 2019
@Exirel Exirel requested a review from dgw August 13, 2019 21:35
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also: .. highlight:: ini can be used to remove the usage of .. code-block:: ini in the whole file, since we don't show Python code in that particular file, but a lot of ini-like code sample.

Might as well do that in another commit. This PR is too small. Only one nemesis to vanquish in this one, anyway—you need more to do! 😝

docs/source/configuration.rst Outdated Show resolved Hide resolved
@Exirel
Copy link
Contributor Author

Exirel commented Sep 2, 2019

@dgw I split in 2 commits, for the highlight.

@dgw
Copy link
Member

dgw commented Sep 3, 2019

Oh, I thought doing the highlight would also mean removing all .. code-block:: ini stuff. Did you miss one, or leave it for a reason?

@Exirel
Copy link
Contributor Author

Exirel commented Sep 3, 2019

or leave it for a reason?

Lazyness? 😁

@dgw
Copy link
Member

dgw commented Sep 4, 2019

or leave it for a reason?

Lazyness? 😁

I removed that excuse by pushing a commit that does it for you. 😸

Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good now, with my added commit to get rid of .. code-block:: ini everywhere.

@dgw
Copy link
Member

dgw commented Sep 5, 2019

#1628 doc-updating game too strong. 😆 Rebased.

@dgw dgw merged commit 3871508 into sopel-irc:master Nov 6, 2019
@Exirel Exirel deleted the doc-config-nick-user-host branch January 14, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants