Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: Ignore more invalid URLs #1788

Merged
merged 1 commit into from
Jan 2, 2020
Merged

url: Ignore more invalid URLs #1788

merged 1 commit into from
Jan 2, 2020

Conversation

half-duplex
Copy link
Member

@half-duplex half-duplex commented Dec 19, 2019 •
edited
Loading

Silently ignores invalid URLs like http:/// and http://.example.com. Includes tests.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No (new...) issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@half-duplex half-duplex added the Bugfix Generally, PRs that reference (and fix) one or more issue(s) label Dec 19, 2019
@half-duplex half-duplex added this to the 7.0.0 milestone Dec 19, 2019
dgw
dgw approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good. This is a nice last-minute bugfix. 🎉

@dgw dgw merged commit b50d1e3 into sopel-irc:master Jan 2, 2020
@half-duplex half-duplex deleted the invalid-urls branch January 3, 2020 17:44
@half-duplex half-duplex restored the invalid-urls branch May 14, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgw dgw dgw approved these changes

@Exirel Exirel Exirel approved these changes

Assignees
No one assigned
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s)
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@half-duplex @dgw @Exirel