search: some Bing fixes (UA spoofing, example test, regex) #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bing results look different than they used to; the HTML has changed a little. Seems like Bing also sends fake "No results" pages to the default requests user-agent, so we now spoof for both DDG and Bing. Not knowing how long this was broken, I added an example test for Bing. Hopefully it will help us catch future breakage, while not becoming an annoyance. If it starts failing at random too often, I'll nuke it. This should also fix the xkcd plugin not being able to find comics by keyword, since it relies on the search plugin's Bing function.
dgw
added
Tweak
Bugfix
|
I already had to kick two of the seven CI builds for this, but only one of those was actually Bing. (The other was some weird-ass mismatch in a Still, though, I'm not sure if this test is a great idea, given my comments in 484aa38 (Aug 2018). |
|
Hoping for #1853 to go in first, in which case I'll update this to take advantage of recorded HTTP requests and bypass the random "No results" issue entirely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bing results look different than they used to; the HTML has changed a little. Seems like Bing also sends fake "No results" pages to the default requests user-agent, so we now spoof for both DDG and Bing.
Not knowing how long this was broken, I added an example test for Bing. Hopefully it will help us catch future breakage, while not becoming an annoyance. If it starts failing at random too often, I'll nuke it.
This should also fix the xkcd plugin not being able to find comics by keyword, since it relies on the search plugin's Bing function.
Checklist
make qa(runsmake qualityandmake test)coverage3and-k 'test_example_bing', so I only paid attention to tests directly related to this change.